Logging trace set to false was ignored (#845)

* Fixed bug where "false" data attribute was a truthy value.
* Fix is to use nil if the value is false.

Author: jonathanphilippou

CHANGELOG.md

@@ -6,6 +6,9 @@ Contributors: please follow the recommendations outlined at [keepachangelog.com]
 ## [Unreleased]
 *Please add entries here for your pull requests.*
 
+## Changed
+- Logging no longer occurs when trace is turned to false. [#845](https://github.com/shakacode/react_on_rails/pull/845) by [conturbo](https://github.com/Conturbo)
+                               
 ## [8.0.0-beta.2] - 2017-05-08
 
 ### Changed

app/helpers/react_on_rails_helper.rb

@@ -111,7 +111,7 @@ def react_component(component_name, raw_options = {})
                                               type: "application/json",
                                               class: "js-react-on-rails-component",
                                               "data-component-name" => options.name,
-                                              "data-trace" => options.trace,
+                                              "data-trace" => (options.trace ? true : nil),
                                               "data-dom-id" => options.dom_id)
 
     # Create the HTML rendering part

spec/dummy/spec/features/rails_context_spec.rb

@@ -30,6 +30,7 @@
         i18nLocale: "en",
         i18nDefaultLocale: "en",
         httpAcceptLanguage: http_accept_language,
+        # railsEnv: Rails.env,
         somethingUseful: "REALLY USEFUL"
       }
 

spec/dummy/spec/helpers/react_on_rails_helper_spec.rb

@@ -83,14 +83,14 @@
     let(:react_definition_script) do
       <<-SCRIPT
 <script type="application/json" class="js-react-on-rails-component" data-component-name="App" \
-data-trace="false" data-dom-id="App-react-component-0">{"name":"My Test Name"}</script>
+data-dom-id="App-react-component-0">{"name":"My Test Name"}</script>
       SCRIPT
     end
 
     let(:react_definition_script_no_params) do
       <<-SCRIPT
 <script type="application/json" class="js-react-on-rails-component" data-component-name="App" \
-data-trace="false" data-dom-id="App-react-component-0">{}</script>
+data-dom-id="App-react-component-0">{}</script>
       SCRIPT
     end
 
@@ -131,14 +131,30 @@
       let(:react_definition_script) do
         <<-SCRIPT
 <script type="application/json" class="js-react-on-rails-component" data-component-name="App" \
-data-trace="false" data-dom-id="shaka_div">{"name":"My Test Name"}</script>
+data-dom-id="shaka_div">{"name":"My Test Name"}</script>
         SCRIPT
       end
 
       it { is_expected.to include id }
       it { is_expected.not_to include react_component_div }
       it { is_expected.to include react_definition_script }
     end
+
+    context "with 'trace' == true" do
+      it "adds the data-trace tag to the component_specification_tag" do
+        result = react_component("App", trace: true)
+
+        expect(result).to match(/data-trace="true"/)
+      end
+    end
+
+    context "with 'trace' == false" do
+      it "does not add the data-trace tag" do
+        result = react_component("App", trace: false)
+
+        expect(result).not_to match(/data-trace=/)
+      end
+    end
   end
 
   describe "#redux_store" do