Check the output of mediacapabilities with MediaSource #3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
requested changes
Jan 24, 2022
lib/util/stream_utils.js
Outdated
| return false; | ||
| } | ||
| } | ||
| videoCodecs = shaka.util.StreamUtils.patchVp9(videoCodecs); |
There was a problem hiding this comment.
For multiplexed streams, this was already done in the branch above. Should this section be in an "else" branch for non-multiplexed only?
There was a problem hiding this comment.
The If only applies to audio content, the else is not necessary because it is always needed for video, anyway I have seen that something was being done wrong and duplicated.
lib/util/stream_utils.js
Outdated
| if (audio) { | ||
| const codecs = | ||
| (audio.codecs.toLowerCase() == 'ac-3' && | ||
| shaka.util.Platform.isTizen()) ? 'ec-3' : audio.codecs; |
There was a problem hiding this comment.
I assume this Tizen-specific logic must already exist in another location, so I think it would be best to encapsulate it in a method somewhere.
joeyparrish
approved these changes
Jan 25, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Jan 28, 2022
The proposed solution checks that all variants, apart from being checked in mediaCapabilities.decodingInfo, are also checked with MediaSource.isTypeSupported There are some browser implementations that return a true mediaCapabilities.decodingInfo for unknown mimetypes and codecs and that can cause an application-level problem. For example, EDGE on Windows 10 returns true to HEVC even if you don't have the extension installed to support HEVC, instead MediaSource.isTypeSupported does take this into account Fixes: #3860
joeyparrish
pushed a commit
that referenced
this pull request
Jan 28, 2022
The proposed solution checks that all variants, apart from being checked in mediaCapabilities.decodingInfo, are also checked with MediaSource.isTypeSupported There are some browser implementations that return a true mediaCapabilities.decodingInfo for unknown mimetypes and codecs and that can cause an application-level problem. For example, EDGE on Windows 10 returns true to HEVC even if you don't have the extension installed to support HEVC, instead MediaSource.isTypeSupported does take this into account Fixes: #3860
joeyparrish
pushed a commit
that referenced
this pull request
Jan 28, 2022
The proposed solution checks that all variants, apart from being checked in mediaCapabilities.decodingInfo, are also checked with MediaSource.isTypeSupported There are some browser implementations that return a true mediaCapabilities.decodingInfo for unknown mimetypes and codecs and that can cause an application-level problem. For example, EDGE on Windows 10 returns true to HEVC even if you don't have the extension installed to support HEVC, instead MediaSource.isTypeSupported does take this into account Fixes: #3860
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3860
The proposed solution checks that all variants, apart from being checked in
mediaCapabilities.decodingInfo, are also checked withMediaSource.isTypeSupportedThere are some browser implementations that return a true
mediaCapabilities.decodingInfofor unknown mimetypes and codecs and that can cause an application-level problem. For example, EDGE on Windows 10 returns true to HEVC even if you don't have the extension installed to support HEVC, insteadMediaSource.isTypeSupporteddoes take this into account