Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add video fullscreen support for iOS #3853

Merged
merged 4 commits into from
Jan 12, 2022
Merged

Add video fullscreen support for iOS #3853

merged 4 commits into from
Jan 12, 2022

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 12, 2022

Fixes: #3832

theodab
theodab requested changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update shakaDemo.Main.unload(), shaka.ads.ClientSideAd.resize(), and shaka.ads.ClientSideAdManager.onAdsManagerLoaded_().

@avelad avelad requested a review from theodab January 12, 2022 08:56
theodab
theodab requested changes Jan 12, 2022
View reviewed changes
lib/ads/client_side_ad_manager.js Outdated Show resolved Hide resolved
lib/ads/client_side_ad_manager.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab January 12, 2022 10:16
theodab
theodab previously approved these changes Jan 12, 2022
View reviewed changes
@theodab
Copy link
Contributor

theodab commented Jan 12, 2022

I can't merge this one, either? Maybe my permissions changed or something.

@joeyparrish
Copy link
Member

Settings should be fixed now. Let me know if I'm wrong!

@theodab theodab merged commit 8d1b5e6 into shaka-project:master Jan 12, 2022
@avelad avelad deleted the video-fullscreen branch January 13, 2022 06:32
@github-actions github-actions bot mentioned this pull request Feb 12, 2022
Closed
@github-actions github-actions bot mentioned this pull request Mar 3, 2022
Merged
@github-actions github-actions bot mentioned this pull request Mar 22, 2022
Closed
@avelad avelad added this to the v4.0 milestone May 4, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish left review comments

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.

When Iphone & set "playsinline" attribute - need to show fullscreen button
3 participants
@avelad @theodab @joeyparrish