Issue/3839-cmcd-property-mangling #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
approved these changes
Jan 10, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Jan 11, 2022
Move CMCD type definition to externs to avoid minifying property names Co-authored-by: Dan Sparacio <[email protected]> Fixes #3839
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move CMCD type definition to externs to avoid minifying property names
Fixes #3839
Screenshots (optional)
Type of change
not work as expected)
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests pass