-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add goToLive method #3527
Add goToLive method #3527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
All tests passed! |
if (this.isLive()) { | ||
this.video_.currentTime = this.seekRange().end; | ||
} else { | ||
shaka.log.warning('goToLive is for live streams!'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want this to show up in production, then revise this to "alwaysWarn". warning() will be removed in production builds.
If you're happy with this only showing up in debug, then it's fine as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a preference, I do what you prefer...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine with me. Just wanted to make sure you knew you had options.
I notices that with Edit: I never managed to get the |
Add goToLive method to the Player. This new method is very useful in live streams.