Force update captions with resizes #3426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellezhuogg
approved these changes
May 26, 2021
|
All tests passed! |
theodab
approved these changes
May 26, 2021
joeyparrish
pushed a commit
that referenced
this pull request
Jun 16, 2021
Backported to v2.5.x and added ResizeObserver and DOMRectReadOnly externs from Closure (not built into the older compiler release used in this branch). This branch also required the addition of a filter in the test environment to remove global errors dispatched by ResizeObserver which should be ignored, but which Jasmine treats as test failures. Change-Id: I17269ec44373bf3303cd1f7eb3c34dcd1c765a66
joeyparrish
pushed a commit
that referenced
this pull request
Jun 16, 2021
joeyparrish
pushed a commit
that referenced
this pull request
Jun 16, 2021
1 task
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are measurements that use absolute values in pixels after a conversion. By making this change we force to update the subtitles that are being shown to have the correct dimensions.
Related to: #3414