Add chapters support #2972
Add chapters support #2972
Conversation
|
@joeyparrish Do you think it can be reviewed and include it in v3.1? |
|
@michellezhuogg I have seen that you are reviewing other PR. Do you think it can be reviewed and include it in v3.1? |
|
I close it because it has been decided to do it at the application level and it is no longer necessary to do it at the player level. |
|
Hello, @avelad @joeyparrish have been any decision made to include chapter support in shaka-player? |
|
The idea was good, but the PR was open for more than 3 months and I couldn't get anyone's attention, that's why I closed it... |
|
Okay, Let's see when it will be available because this is a good feature. |
|
Hi @hiren3897, @avelad, Please accept our apologies for not reviewing this. It has nothing to do with the content or a lack of interest in the feature. We have a lot of work to do on this team to improve responsiveness to PRs. @avelad, I am in the middle of some urgent bug fixes right now, but if you are still interested, I would be happy to reopen the PR now and schedule time to discuss and review it later. |
|
I'm on vacation this week and next week, but I'll continue work. |
|
Updated and synchronized with the latest from the repo. @joeyparrish , can you review? |
| @@ -4371,6 +4467,102 @@ shaka.Player = class extends shaka.util.FakeEventTarget { | |||
| return shaka.util.StreamUtils.textStreamToTrack(stream); | |||
| } | |||
|
|
|||
| /** | |||
| * Adds the given chapters track to the loaded manifest. <code>load()</code> | |||
There was a problem hiding this comment.
Does DASH offer a way to include a chapters track reference in the manifest? Or will it always have to be side-loaded for DASH content?
Does HLS offer a way to include a chapters track in a playlist? If so, does Apple's native HLS expose them through video.textTracks?
There was a problem hiding this comment.
As far as I know, both DASH and HLS do not offer this functionality and it is always side-loaded
|
All tests passed! |
|
This will first appear in v3.2. Thanks for your patience with us! |
|
Hello @joeyparrish @avelad I am eagerly waiting for this one. Thank you so much :) cheers! 🥳 |
|
@joeyparrish do you have any estimated ETA for 3.2? |
|
I discussed this today with @michellezhuogg, who implemented the major feature we were targeting for v3.2, and we will discuss it more broadly with the rest of the Shaka team on Monday. If we don't find any reason to delay the launch of v3.2, we could launch it as early as next week. |
|
@joeyparrish Can you add version 3.2 to this PR? |
|
Sure. |
|
Hello @avelad @joeyparrish. Do we have any tutorials on how to add/get chapters support to the player? Or do we have to add chapters manually? using And the list of chapters should be present inside the Manifest so that the functions this.player.getChapters('en')
this.player.getChaptersTracks()will return the list of chapters so that we can use them to populate on the timeline? Thank you In advance :) |
github-actions
bot
added
the
status: archived
Add the following methods:
The following formats are supported: WebVTT and SRT