Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid launch RESTRICTIONS_CANNOT_BE_MET when it's not necessary #8014

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Feb 4, 2025

This can happen with HLS, when there is Widevine with keyId and PlayReady without keyId and the system only supports Playready.

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Feb 4, 2025
@avelad avelad added this to the v4.14 milestone Feb 4, 2025
@avelad avelad force-pushed the RESTRICTIONS_CANNOT_BE_MET branch from 94b719e to e82af53 Compare February 4, 2025 15:30
This can happen with HLS, when there is Widevine with keyId and PlayReady without keyId and the system only supports Playready.
@avelad avelad force-pushed the RESTRICTIONS_CANNOT_BE_MET branch from e82af53 to 330d00c Compare February 4, 2025 15:47
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

lib/player.js Show resolved Hide resolved
lib/player.js Show resolved Hide resolved
@avelad avelad requested a review from joeyparrish February 4, 2025 18:08
@avelad avelad dismissed joeyparrish’s stale review February 5, 2025 12:40

Approved by Wojciech

@avelad avelad merged commit ece88d6 into shaka-project:main Feb 5, 2025
17 checks passed
@avelad avelad deleted the RESTRICTIONS_CANNOT_BE_MET branch February 5, 2025 12:41
avelad added a commit that referenced this pull request Feb 5, 2025
…8014)

This can happen with HLS, when there is Widevine with keyId and
PlayReady without keyId and the system only supports Playready.
avelad added a commit that referenced this pull request Feb 5, 2025
…8014)

This can happen with HLS, when there is Widevine with keyId and
PlayReady without keyId and the system only supports Playready.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants