fix(CMCD): Only report ltc if playing; round to int #8011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
avelad
changed the title
|
Incremental code coverage: 100.00% |
costela
force-pushed
the
leo.antunes/fix-cmcd-ltc
branch
from
5a793c3 to
2ea26e5
Compare
|
ℹ️ just added a couple of unit tests to cover the spotted two edge-cases 🤞 |
costela
force-pushed
the
leo.antunes/fix-cmcd-ltc
branch
from
2ea26e5 to
ed82707
Compare
costela
force-pushed
the
leo.antunes/fix-cmcd-ltc
branch
from
ed82707 to
1e2f7a2
Compare
|
🤔 local test run somehow didn't catch the errors. |
joeyparrish
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Looks good to me. I tried to Google "cmcd ltc" to double-check that the format indeed wants an integer, but the first result for me was #8010. 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8010