Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix setLiveSeekableRange when the seekable range is too short #7916

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 21, 2025

Some older devices require the range to be greater than 1 or exceptions are thrown, due to an old and buggy implementation.

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Jan 21, 2025
@avelad avelad added this to the v4.13 milestone Jan 21, 2025
@avelad avelad requested review from theodab and tykus160 January 21, 2025 09:28
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 30be525 into shaka-project:main Jan 21, 2025
17 of 18 checks passed
@avelad avelad deleted the setLiveSeekableRange-error branch January 22, 2025 08:57
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 22, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants