Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ABR): Use PiP window size when using requestPictureInPicture #7882

Merged
merged 2 commits into from
Jan 13, 2025
Merged

feat(ABR): Use PiP window size when using requestPictureInPicture #7882

merged 2 commits into from
Jan 13, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 13, 2025

Close #7872

@avelad avelad mentioned this pull request Jan 13, 2025
Closed
@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels Jan 13, 2025
@avelad avelad added this to the v4.13 milestone Jan 13, 2025
@shaka-bot
Copy link
Collaborator

shaka-bot commented Jan 13, 2025 •
edited
Loading

Incremental code coverage: 39.39%

@avelad avelad requested a review from tykus160 January 13, 2025 14:41
@avelad avelad merged commit a583c4a into shaka-project:main Jan 13, 2025
18 checks passed
@shaka-bot shaka-bot mentioned this pull request Jan 13, 2025
Merged
@avelad avelad deleted the abr-pip branch January 15, 2025 08:49
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 14, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tykus160 tykus160 tykus160 approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.

Use PiP window size when abr.restrictToElementSize is true
3 participants
@avelad @shaka-bot @tykus160