fix: Fix SEGMENT HEAD requests, compatibility with Cast SDK #7851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cast SDK currently assumes that SEGMENT response objects always have data, however this stopped being true for HEAD requests in v4.3.6. This PR fixes the behavior of the Fetch plugin so that HEAD requests will at least have an empty ArrayBuffer for data, as they did in v4.3.5 and earlier. The Cast SDK will also receive a fix to stop assuming this, fixing compatibility with v4.3.6+ - v4.12.6. This incompatibility between the current Cast SDK and these versions of Shaka Player is only triggered by HLS content whose segment URLs have no recognizable extension. Affected Shaka Player versions: - v4.3.6 - v4.3.16 - v4.4.x - v4.8.x - v4.9.0 - v4.9.34 - v4.9.2-caf - v4.9.2-caf4 - v4.10.x - v4.11.0 - v4.11.18 - v4.12.0 - v4.12.6 Affected Cast Web Receiver SDK versions: - <= 3.0.0137 Fixes will be in: - v4.9.35+ - v4.9.2-caf5+ - v4.11.19+ - v4.12.7+ - v4.13.0+ Closes shaka-project#7600
|
Incremental code coverage: 100.00% |
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
tykus160
approved these changes
Jan 9, 2025
avelad
added
type: bug
avelad
approved these changes
Jan 9, 2025
avelad
pushed a commit
that referenced
this pull request
Jan 10, 2025
The Cast SDK currently assumes that SEGMENT response objects always have data, however this stopped being true for HEAD requests in v4.3.6. This PR fixes the behavior of the Fetch plugin so that HEAD requests will at least have an empty ArrayBuffer for data, as they did in v4.3.5 and earlier. The Cast SDK will also receive a fix to stop assuming this, fixing compatibility with v4.3.6+ - v4.12.6. This incompatibility between the current Cast SDK and these versions of Shaka Player is only triggered by HLS content whose segment URLs have no recognizable extension. Affected Shaka Player versions: - v4.3.6 - v4.3.16 - v4.4.x - v4.8.x - v4.9.0 - v4.9.34 - v4.9.2-caf - v4.9.2-caf4 - v4.10.x - v4.11.0 - v4.11.18 - v4.12.0 - v4.12.6 Affected Cast Web Receiver SDK versions: - <= 3.0.0137 Fixes will be in: - v4.9.35+ - v4.9.2-caf5+ - v4.11.19+ - v4.12.7+ - v4.13.0+ Closes #7600
avelad
pushed a commit
that referenced
this pull request
Jan 10, 2025
The Cast SDK currently assumes that SEGMENT response objects always have data, however this stopped being true for HEAD requests in v4.3.6. This PR fixes the behavior of the Fetch plugin so that HEAD requests will at least have an empty ArrayBuffer for data, as they did in v4.3.5 and earlier. The Cast SDK will also receive a fix to stop assuming this, fixing compatibility with v4.3.6+ - v4.12.6. This incompatibility between the current Cast SDK and these versions of Shaka Player is only triggered by HLS content whose segment URLs have no recognizable extension. Affected Shaka Player versions: - v4.3.6 - v4.3.16 - v4.4.x - v4.8.x - v4.9.0 - v4.9.34 - v4.9.2-caf - v4.9.2-caf4 - v4.10.x - v4.11.0 - v4.11.18 - v4.12.0 - v4.12.6 Affected Cast Web Receiver SDK versions: - <= 3.0.0137 Fixes will be in: - v4.9.35+ - v4.9.2-caf5+ - v4.11.19+ - v4.12.7+ - v4.13.0+ Closes #7600
joeyparrish
added a commit
that referenced
this pull request
Jan 10, 2025
The Cast SDK currently assumes that SEGMENT response objects always have data, however this stopped being true for HEAD requests in v4.3.6. This PR fixes the behavior of the Fetch plugin so that HEAD requests will at least have an empty ArrayBuffer for data, as they did in v4.3.5 and earlier. The Cast SDK will also receive a fix to stop assuming this, fixing compatibility with v4.3.6+ - v4.12.6. This incompatibility between the current Cast SDK and these versions of Shaka Player is only triggered by HLS content whose segment URLs have no recognizable extension. Affected Shaka Player versions: - v4.3.6 - v4.3.16 - v4.4.x - v4.8.x - v4.9.0 - v4.9.34 - v4.9.2-caf - v4.9.2-caf4 - v4.10.x - v4.11.0 - v4.11.18 - v4.12.0 - v4.12.6 Affected Cast Web Receiver SDK versions: - <= 3.0.0137 Fixes will be in: - v4.9.35+ - v4.9.2-caf5+ - v4.11.19+ - v4.12.7+ - v4.13.0+ Closes #7600
joeyparrish
added a commit
that referenced
this pull request
Jan 10, 2025
The Cast SDK currently assumes that SEGMENT response objects always have data, however this stopped being true for HEAD requests in v4.3.6. This PR fixes the behavior of the Fetch plugin so that HEAD requests will at least have an empty ArrayBuffer for data, as they did in v4.3.5 and earlier. The Cast SDK will also receive a fix to stop assuming this, fixing compatibility with v4.3.6+ - v4.12.6. This incompatibility between the current Cast SDK and these versions of Shaka Player is only triggered by HLS content whose segment URLs have no recognizable extension. Affected Shaka Player versions: - v4.3.6 - v4.3.16 - v4.4.x - v4.8.x - v4.9.0 - v4.9.34 - v4.9.2-caf - v4.9.2-caf4 - v4.10.x - v4.11.0 - v4.11.18 - v4.12.0 - v4.12.6 Affected Cast Web Receiver SDK versions: - <= 3.0.0137 Fixes will be in: - v4.9.35+ - v4.9.2-caf5+ - v4.11.19+ - v4.12.7+ - v4.13.0+ Closes #7600 Release-As: 4.9.2-caf5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cast SDK currently assumes that SEGMENT response objects always have data, however this stopped being true for HEAD requests in v4.3.6.
This PR fixes the behavior of the Fetch plugin so that HEAD requests will at least have an empty ArrayBuffer for data, as they did in v4.3.5 and earlier.
The Cast SDK will also receive a fix to stop assuming this, fixing compatibility with v4.3.6+ - v4.12.6.
This incompatibility between the current Cast SDK and these versions of Shaka Player is only triggered by HLS content whose segment URLs have no recognizable extension.
Affected Shaka Player versions:
Affected Cast Web Receiver SDK versions:
Fixes will be in:
Closes #7600