Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Ads): Simplify quartile management in Interstitials #7689

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 28, 2024

No description provided.

@avelad avelad added type: code health A code health issue component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Nov 28, 2024
@avelad avelad added this to the v4.13 milestone Nov 28, 2024
@avelad
Copy link
Member Author

avelad commented Nov 28, 2024

@shaka-bot test ce

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7689
  • browser_filter=Tizen ChromecastUltra ChromecastGTV ChromeAndroid

@avelad avelad merged commit 1236c2d into shaka-project:main Nov 28, 2024
21 of 22 checks passed
@avelad avelad deleted the simplify-quartile-events branch November 28, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround type: code health A code health issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants