Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(Ads): Add more basic Interstitials unit tests #7687

Merged
merged 5 commits into from
Nov 28, 2024
Merged

test(Ads): Add more basic Interstitials unit tests #7687

merged 5 commits into from
Nov 28, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 28, 2024

No description provided.

@avelad
Copy link
Member Author

avelad commented Nov 28, 2024

@tykus160 It is necessary to merge #7686 first because a bug has been discovered with these tests :)

@avelad avelad requested review from theodab and tykus160 November 28, 2024 11:51
@avelad avelad added the component: tests The issue involves our automated tests (generally; otherwise use a more specific component) label Nov 28, 2024
@avelad avelad added this to the v4.13 milestone Nov 28, 2024
@avelad
Copy link
Member Author

avelad commented Nov 28, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7687

@avelad avelad mentioned this pull request Nov 28, 2024
Merged
@avelad
Copy link
Member Author

avelad commented Nov 28, 2024

@shaka-bot test ce

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7687
  • browser_filter=Tizen ChromecastUltra ChromecastGTV ChromeAndroid

@avelad
Copy link
Member Author

avelad commented Nov 28, 2024

@shaka-bot test ce

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7687
  • browser_filter=Tizen ChromecastUltra ChromecastGTV ChromeAndroid

@avelad avelad merged commit f6b7a41 into shaka-project:main Nov 28, 2024
21 of 22 checks passed
@avelad avelad deleted the interstitials-tests branch November 28, 2024 15:53
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 27, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tykus160 tykus160 tykus160 approved these changes

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: tests The issue involves our automated tests (generally; otherwise use a more specific component) status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @tykus160