Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS Interstitial behaviour when user JUMPS across more than one interstitial #7665

Closed
matthardiman-itv opened this issue Nov 25, 2024 · 0 comments · Fixed by #7667
Closed
Assignees
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Milestone

Comments

@matthardiman-itv
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

Not DRM related

What version of Shaka Player are you using?

v4.12.2

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Demo App ( https://shaka-player-demo.appspot.com/ )

If custom app, can you reproduce the issue using our demo app?
n/a

What browser and OS are you using?
Windows 11 & Chrome 131

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
n/a

What are the manifest and license server URIs?

Manifest https://d246vxj7zy7k76.cloudfront.net/bbb/main_is.m3u8 which includes 3 midroll asset lists - https://d246vxj7zy7k76.cloudfront.net/adlists/list_midroll1.json https://d246vxj7zy7k76.cloudfront.net/adlists/list_midroll2.json and https://d246vxj7zy7k76.cloudfront.net/adlists/list_midroll3.json

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

Default

What did you do?

Created an HLS packaged asset using Shaka Packager, Edited the media manifests to add 5 Interstitial links (1 pre-roll, 3 mid-rolls and 1 post-roll)
#EXT-X-DATERANGE:ID="PREROLL",CLASS="com.apple.hls.interstitial",CUE="PRE",START-DATE="2020-01-01T00:00:00.000Z",X-ASSET-LIST="https://d246vxj7zy7k76.cloudfront.net/adlists/list_preroll.json",X-RESUME-OFFSET=0.0,X-RESTRICT="SKIP,JUMP"
#EXT-X-DATERANGE:ID="1",CLASS="com.apple.hls.interstitial",CUE="ONCE",START-DATE="2020-01-01T00:02:00.000Z",X-ASSET-LIST="https://d246vxj7zy7k76.cloudfront.net/adlists/list_midroll1.json",X-RESUME-OFFSET=0.0,X-RESTRICT="SKIP,JUMP"
#EXT-X-DATERANGE:ID="2",CLASS="com.apple.hls.interstitial",CUE="ONCE",START-DATE="2020-01-01T00:04:00.000Z",X-ASSET-LIST="https://d246vxj7zy7k76.cloudfront.net/adlists/list_midroll2.json",X-RESUME-OFFSET=0.0,X-RESTRICT="SKIP,JUMP"
#EXT-X-DATERANGE:ID="3",CLASS="com.apple.hls.interstitial",CUE="ONCE",START-DATE="2020-01-01T00:06:00.000Z",X-ASSET-LIST="https://d246vxj7zy7k76.cloudfront.net/adlists/list_midroll3.json",X-RESUME-OFFSET=0.0,X-RESTRICT="SKIP,JUMP"
#EXT-X-DATERANGE:ID="POSTROLL",CLASS="com.apple.hls.interstitial",CUE="POST",START-DATE="2020-01-01T00:20:00.000Z",X-ASSET-LIST="https://d246vxj7zy7k76.cloudfront.net/adlists/list_postroll.json",X-RESUME-OFFSET=0.0,X-RESTRICT="SKIP,JUMP"

The midrolls are at 02:00, 04:00 and 06:00 minutes into the content.

What did you expect to happen?
If the user is currently playing at a time before the first mid-roll (e.g. 01:00) and then changes the player location to after the last mid-roll (e.g. 07:00), I would expect only 1 mid-roll to play - not 100% sure which one, probably the first but not all 3.

What actually happened?

When the user is at a playback location before the first mid-roll (e.g. 01:00) and they move to a point after the last mid-roll (e.g. 07:00) all 3 mid-rolls play - starting with the 3rd, then the 2nd and finally the 1st

Are you planning send a PR to fix it?
unfortunately I don't have sufficient knowledge to offer a PR

@matthardiman-itv matthardiman-itv added the type: bug Something isn't working correctly label Nov 25, 2024
@avelad avelad self-assigned this Nov 25, 2024
@avelad avelad added component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release labels Nov 25, 2024
@avelad avelad added this to the v4.13 milestone Nov 25, 2024
@avelad avelad closed this as completed in 4aa9306 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants