Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PS5): Prevent uncaught promise rejections when requests are aborted #7637

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

tykus160
Copy link
Member

On PS5 we are seeing following uncaught exceptions when requests are aborted:

[Error] Fetch is aborted – PromiseRejectionEvent {isTrusted: false, promise: Promise, reason: AbortError: Fetch is aborted, …}
PromiseRejectionEvent {isTrusted: false, promise: Promise, reason: AbortError: Fetch is aborted, type: "unhandledrejection", target: Window, …}PromiseRejectionEvent
	(anonymous function) (Anonymous Script 1 (line 429))
[Error] Unhandled Promise Rejection: AbortError: Fetch is aborted
	promiseEmptyOnRejected
	promiseReactionJob

@tykus160 tykus160 added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround platform: Playstation 5 Issues affecting Playstation 5 labels Nov 20, 2024
@tykus160 tykus160 added this to the v4.13 milestone Nov 20, 2024
@avelad avelad merged commit 09cfac2 into shaka-project:main Nov 20, 2024
22 of 23 checks passed
avelad pushed a commit that referenced this pull request Nov 27, 2024
…ed (#7637)

On PS5 we are seeing following uncaught exceptions when requests are
aborted:
```
[Error] Fetch is aborted – PromiseRejectionEvent {isTrusted: false, promise: Promise, reason: AbortError: Fetch is aborted, …}
PromiseRejectionEvent {isTrusted: false, promise: Promise, reason: AbortError: Fetch is aborted, type: "unhandledrejection", target: Window, …}PromiseRejectionEvent
	(anonymous function) (Anonymous Script 1 (line 429))
[Error] Unhandled Promise Rejection: AbortError: Fetch is aborted
	promiseEmptyOnRejected
	promiseReactionJob
```
avelad pushed a commit that referenced this pull request Nov 27, 2024
…ed (#7637)

On PS5 we are seeing following uncaught exceptions when requests are
aborted:
```
[Error] Fetch is aborted – PromiseRejectionEvent {isTrusted: false, promise: Promise, reason: AbortError: Fetch is aborted, …}
PromiseRejectionEvent {isTrusted: false, promise: Promise, reason: AbortError: Fetch is aborted, type: "unhandledrejection", target: Window, …}PromiseRejectionEvent
	(anonymous function) (Anonymous Script 1 (line 429))
[Error] Unhandled Promise Rejection: AbortError: Fetch is aborted
	promiseEmptyOnRejected
	promiseReactionJob
```
joeyparrish pushed a commit that referenced this pull request Dec 11, 2024
…ed (#7637)

On PS5 we are seeing following uncaught exceptions when requests are
aborted:
```
[Error] Fetch is aborted – PromiseRejectionEvent {isTrusted: false, promise: Promise, reason: AbortError: Fetch is aborted, …}
PromiseRejectionEvent {isTrusted: false, promise: Promise, reason: AbortError: Fetch is aborted, type: "unhandledrejection", target: Window, …}PromiseRejectionEvent
	(anonymous function) (Anonymous Script 1 (line 429))
[Error] Unhandled Promise Rejection: AbortError: Fetch is aborted
	promiseEmptyOnRejected
	promiseReactionJob
```
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 19, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: Playstation 5 Issues affecting Playstation 5 priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants