fix(HLS): Fix subtitle timing #7625
Merged
+84
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
avelad
force-pushed
the
hls-subtitles
branch
2 times, most recently
from
51ee777 to
a21aedd
Compare
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
avelad
force-pushed
the
hls-subtitles
branch
from
a21aedd to
abcc6ae
Compare
Simplifies subtitle management for sequence mode and segments mode Runs subtitle tests in segments mode as well
avelad
force-pushed
the
hls-subtitles
branch
from
abcc6ae to
94c7b48
Compare
littlespex
approved these changes
Nov 19, 2024
joeyparrish
pushed a commit
that referenced
this pull request
Nov 19, 2024
Simplifies subtitle management for sequence mode and segments mode Runs subtitle tests in segments mode as well (Tizen 3.0) Fixes: #7447
joeyparrish
pushed a commit
that referenced
this pull request
Nov 19, 2024
Simplifies subtitle management for sequence mode and segments mode Runs subtitle tests in segments mode as well (Tizen 3.0) Fixes: #7447
joeyparrish
pushed a commit
that referenced
this pull request
Nov 19, 2024
Simplifies subtitle management for sequence mode and segments mode Runs subtitle tests in segments mode as well (Tizen 3.0) Fixes: #7447
This was referenced Nov 19, 2024
|
This fix seems to introduce a new bug 4.12.2/4.11.14 introduces subtitles with HLS streams being out of sync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies subtitle management for sequence mode and segments mode
Runs subtitle tests in segments mode as well (Tizen 3.0)
Fixes: #7447