Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Calculate timeToFirstByte before fire the event 'downloadheadersreceived' #7605

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: Calculate timeToFirstByte before fire the event 'downloadheadersreceived' #7605

merged 1 commit into from
Nov 15, 2024

Conversation

vlazh
Copy link
Contributor

@vlazh vlazh commented Nov 15, 2024 •
edited by avelad
Loading

Fixes #7604

@avelad avelad changed the title Move up timeToFirstByte calculation feat: Calculate timeToFirstByte before fire the event 'downloadheadersreceived' Nov 15, 2024
@vlazh vlazh changed the title feat: Calculate timeToFirstByte before fire the event 'downloadheadersreceived' fix: Move up timeToFirstByte calculation Nov 15, 2024
@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent component: networking The issue involves the networking system of Shaka Player labels Nov 15, 2024
@avelad avelad added this to the v4.13 milestone Nov 15, 2024
@avelad avelad changed the title fix: Move up timeToFirstByte calculation feat: Calculate timeToFirstByte before fire the event 'downloadheadersreceived' Nov 15, 2024
@tykus160 tykus160 changed the title feat: Calculate timeToFirstByte before fire the event 'downloadheadersreceived' fix: Calculate timeToFirstByte before fire the event 'downloadheadersreceived' Nov 15, 2024
@tykus160 tykus160 added type: bug Something isn't working correctly and removed type: enhancement New feature or request labels Nov 15, 2024
@avelad avelad merged commit 0fc5316 into shaka-project:main Nov 15, 2024
30 of 31 checks passed
@shaka-bot shaka-bot mentioned this pull request Nov 15, 2024
Merged
avelad pushed a commit that referenced this pull request Nov 15, 2024
@vlazh @avelad
fix: Calculate timeToFirstByte before fire the event 'downloadheaders…
ceeb264 
…received' (#7605)

Fixes #7604
@shaka-bot shaka-bot mentioned this pull request Nov 15, 2024
Merged
avelad pushed a commit that referenced this pull request Nov 15, 2024
@vlazh @avelad
fix: Calculate timeToFirstByte before fire the event 'downloadheaders…
e7e285b 
…received' (#7605)

Fixes #7604
@shaka-bot shaka-bot mentioned this pull request Nov 15, 2024
Merged
@vlazh vlazh deleted the patch-1 branch November 15, 2024 15:13
joeyparrish pushed a commit that referenced this pull request Nov 19, 2024
@vlazh @joeyparrish
fix: Calculate timeToFirstByte before fire the event 'downloadheaders…
48a362e 
…received' (#7605)

Fixes #7604
@shaka-bot shaka-bot mentioned this pull request Nov 19, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 14, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tykus160 tykus160 tykus160 approved these changes

@avelad avelad avelad approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: networking The issue involves the networking system of Shaka Player priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.

Calculate timeToFirstByte before fire the event 'downloadheadersreceived'
4 participants
@vlazh @avelad @tykus160 @shaka-bot