Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ads): Don't load useless segments when using playoutLimit on interstitial ads #7469

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Oct 22, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Oct 22, 2024
@avelad avelad added this to the v4.12 milestone Oct 22, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 90.00%

@avelad avelad merged commit 7d8510b into shaka-project:main Oct 23, 2024
22 of 23 checks passed
@avelad avelad deleted the playoutLimit-interstitials branch October 23, 2024 06:12
avelad added a commit that referenced this pull request Oct 24, 2024
avelad added a commit that referenced this pull request Oct 24, 2024
avelad added a commit that referenced this pull request Oct 24, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 22, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants