feat: Add configuration to ignore SCTE214 supplemental codecs #7455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 6a519767d96d9610c6d41b531352b75fdfb14705 Author: Gregory McGarry <[email protected]> Date: Wed Aug 7 14:23:20 2024 +1000 Add missing comma. commit e3ee8a42d1eec45ae4250fc45d609da3497cc35f Author: Gregory McGarry <[email protected]> Date: Wed Aug 7 12:11:41 2024 +1000 Add ignoreSupplementalCodecs into the right place for HLS. commit 65344bc69426d8d46b33a445acac300da7b5ea68 Author: Gregory McGarry <[email protected]> Date: Wed Aug 7 09:55:16 2024 +1000 Also ignore SUPPLEMENTAL-CODECS attribute in HLS manifest. commit 5a4c9af6320007f0e293ae68fcee4ebb445bba3f Author: Gregory McGarry <[email protected]> Date: Fri Jul 19 14:51:01 2024 +1000 Provide configuration switch to disable supplementalCodecs.
avelad
changed the title
avelad
added
type: enhancement
|
Please fix the lint errors, thanks! |
tykus160
reviewed
Oct 21, 2024
| @@ -1189,6 +1190,10 @@ shaka.extern.xml.Node; | |||
| * If false, disables fast switching track recognition. | |||
| * <br> | |||
| * Defaults to <code>true</code>. | |||
| * @property {boolean} ignoreSupplementalCodecs | |||
| * If false, ignores supplemental codecs | |||
joeyparrish
reviewed
Oct 21, 2024
| @@ -1294,6 +1300,10 @@ shaka.extern.DashManifestConfiguration; | |||
| * https://www.akamai.com/blog/performance/-using-ll-hls-with-byte-range-addressing-to-achieve-interoperabi | |||
| * <br> | |||
| * Defaults to <code>true</code>. | |||
| * @property {boolean} ignoreSupplementalCodecs | |||
| * If false, ignores supplemental codecs | |||
avelad
added
the
status: waiting on response
|
Closing due to inactivity. If the author would like to continue this PR, they can reopen it (preferred) or start a new one (if needed). |
shaka-bot
removed
the
status: waiting on response
|
I have made some revisions to address the comments. Can this PR be re-opened? |
Any update? |
|
I'm going to create a separate PR with all the necessary fixes, it seems that when you created the PR you didn't check the option to allow maintainers to edit your PR :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCTE214 Supplemental codecs defines an attribute to AdaptationSet and Representation in the DASH manifest, to define alternative names of the media codec. These attributes are recommended to be used for codec extensions such as Dolby Vision Profile 8.
There are some issues with the ecosystem:
For these reasons, having a configuration parameter to disable support for supplementalCodecs is useful.