-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DASH): Update Configuration for Chromecast devices #7446
Conversation
Incremental code coverage: 100.00% |
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
BTW i have 50 as value for CC3 but not sure to properly set it to 50 only for CC3 |
@Iragne from what I understand, |
Yeah, I appreciate this, but I think we have to be careful with a change to the default for all of Chromecast. In particular because we push out new Chromecast SDKs (and their default Shaka versions) in a way that impacts all apps globally, even the ones who have no awareness of what's happening under the hood. It's different when you build your own app and integrate the Shaka Player version of your choice directly. To be clear, I'm not saying "no" to this, but I think I need to be a little more careful before releasing this change. I think it may need to be coordinated with limits to the availability window, because the initial segment limit only changes what happens at startup, not what accumulates over time. Also, we may want to consider combining these low-memory-related changes into a single flag. Maybe Chromecast Gen 3 isn't the only device that could benefit, so maybe we enable that flag by default for many different device types. And also we might want to avoid that flag by default for newer Cast devices with more memory and higher speeds. |
@tykus160 maybe I'm wrong but it's used only under context of } else if (info.segmentDuration) {. @joeyparrish I agree with your approach. And that is true for other devices such as PS, some Tizen, Setupbox, and nesthub... I'm happy to get all your feedback and propose another approach. I will check how i can combine it with other parameter and devices. May i can ask how i can properly distinguish the default Chromecast SDK integration compare to the custom one ? |
I'm not sure what you mean by that. |
Sorry for the late answer. Reading you comment, I understand you would like to make the difference with the shaka player directly avaiable in chromecast compare to a custom cast reciver. Am I wrong ? if it's the case, we should need to be able to differentiate the 2 use case and i'm not sure to properly know how to do it. |
@Iragne, sorry for being unclear. I'll try to clarify what I said before:
|
Closing due to inactivity. If the author would like to continue this PR, they can reopen it (preferred) or start a new one (if needed). |
Clear sorry i was working on other stuff. Thanks @joeyparrish |
Update Configuration for Chromecast devices to limit the memory consumption on VOD playback and also for live
Fixes #7395