-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(DRM): pass preferredKeySystems
to filterManifest()
#6468
perf(DRM): pass preferredKeySystems
to filterManifest()
#6468
Conversation
Incremental code coverage: 100.00% |
I see the "perf" label... Do you have any rough data on how much of a performance improvement this is? |
@joeyparrish previous PR reduced load i.e. on Xbox Series S from ~400 ms to ~100 ms as it avoided 10 calls to widevine. This one does relatively the same, but on manifest updates. |
@tykus160 Since Xbox only supports PlayReady, I wonder if, given this improvement, we should add the default PlayReady |
@avelad recently shaka added some platform-dependant logic, so I'd say adding by default
* Chrome is tricky though, as Chromium-based platforms would be also affected, i.e. |
ClearKey it's necessary, so, for me the platforms are Xbox and PlayStation since only supports PlayReady . ClearKey support will eventually come to Safari, so I don't want to limit the platform. |
Follow up to #5391
Always use
preferredKeySystems
during manifest filtering, not only via DRM Engine.