-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UI): UI support for VR content #6450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
New feature or request
component: UI
The issue involves the Shaka Player UI
priority: P3
Useful but not urgent
labels
Apr 16, 2024
Demo: vr_demo.mp4 |
Incremental code coverage: 73.17% |
avelad
force-pushed
the
ui-vr-support
branch
2 times, most recently
from
April 17, 2024 13:32
119f0fd
to
0a9cb86
Compare
theodab
requested changes
Apr 18, 2024
joeyparrish
requested changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't finished reviewing, but thought I would give a little feedback now.
theodab
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me, now.
joeyparrish
requested changes
Apr 23, 2024
It is important to tear down synchronous children of Controls before the async teardown of the Player.
joeyparrish
approved these changes
Apr 23, 2024
joeyparrish
approved these changes
Apr 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
component: UI
The issue involves the Shaka Player UI
priority: P3
Useful but not urgent
status: archived
Archived and locked; will not be updated
type: enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.