Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): UI support for VR content #6450

Merged
merged 38 commits into from
Apr 25, 2024
Merged

Conversation

avelad
Copy link
Member

@avelad avelad commented Apr 16, 2024

No description provided.

@avelad avelad added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent labels Apr 16, 2024
@avelad avelad added this to the v5.0 milestone Apr 16, 2024
@avelad
Copy link
Member Author

avelad commented Apr 16, 2024

Demo:

vr_demo.mp4

@shaka-bot
Copy link
Collaborator

shaka-bot commented Apr 16, 2024

Incremental code coverage: 73.17%

@avelad avelad force-pushed the ui-vr-support branch 2 times, most recently from 119f0fd to 0a9cb86 Compare April 17, 2024 13:32
ui/externs/ui.js Show resolved Hide resolved
ui/controls.js Show resolved Hide resolved
docs/tutorials/ui.md Outdated Show resolved Hide resolved
ui/externs/ui.js Outdated Show resolved Hide resolved
ui/gl_matrix/matrix_4x4.js Outdated Show resolved Hide resolved
ui/vr_webgl.js Outdated Show resolved Hide resolved
ui/vr_webgl.js Outdated Show resolved Hide resolved
ui/vr_webgl.js Outdated Show resolved Hide resolved
ui/vr_webgl.js Outdated Show resolved Hide resolved
ui/vr_webgl.js Show resolved Hide resolved
@avelad avelad requested a review from theodab April 18, 2024 10:46
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't finished reviewing, but thought I would give a little feedback now.

README.md Outdated Show resolved Hide resolved
ui/controls.js Outdated Show resolved Hide resolved
ui/controls.js Outdated Show resolved Hide resolved
ui/controls.js Show resolved Hide resolved
@avelad avelad requested a review from joeyparrish April 19, 2024 09:31
theodab

This comment was marked as outdated.

Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me, now.

docs/tutorials/ui.md Outdated Show resolved Hide resolved
ui/gl_matrix/matrix_4x4.js Outdated Show resolved Hide resolved
ui/gl_matrix/matrix_quaternion.js Outdated Show resolved Hide resolved
ui/ui.js Outdated Show resolved Hide resolved
ui/controls.js Show resolved Hide resolved
test/text/text_displayer_layout_unit.js Outdated Show resolved Hide resolved
test/ui/ad_ui_unit.js Outdated Show resolved Hide resolved
test/ui/ui_integration.js Outdated Show resolved Hide resolved
test/ui/ui_unit.js Outdated Show resolved Hide resolved
test/ui/ui_customization_unit.js Show resolved Hide resolved
@avelad avelad merged commit 95c6a7d into shaka-project:main Apr 25, 2024
27 of 30 checks passed
@avelad avelad deleted the ui-vr-support branch April 25, 2024 11:43
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 24, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants