Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Ads): Skip play detection in some devices #6443

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Apr 15, 2024

This configuration solves problems with some devices not being able to play a pre-roll.

@avelad avelad added type: enhancement New feature or request component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent labels Apr 15, 2024
@avelad avelad added this to the v5.0 milestone Apr 15, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 91.67%

lib/util/player_configuration.js Outdated Show resolved Hide resolved
externs/shaka/player.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab April 16, 2024 06:10
@avelad avelad merged commit 91f74e7 into shaka-project:main Apr 16, 2024
14 of 16 checks passed
@avelad avelad deleted the ads-play-detection branch April 16, 2024 06:49
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 15, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants