Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Looser tolerance for ending trick play at edge of seek range. #6422

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

david-hm-morgan
Copy link
Contributor

@david-hm-morgan david-hm-morgan commented Apr 9, 2024

Fixes #6421

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Apr 9, 2024
@avelad avelad added this to the v5.0 milestone Apr 9, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 0.00%

@avelad avelad requested a review from littlespex April 9, 2024 15:41
@theodab
Copy link
Contributor

theodab commented Apr 9, 2024

Sadly, I don't think "sub-second" has a good antonym, so there's not a great name for this PR... Let's see.

@theodab theodab changed the title fix: 1 sec accuracy for cancelTrickPlay() at seekable limits fix: Looser tolerance for ending trick play at edge of seek range. Apr 9, 2024
@theodab theodab merged commit 9f603ad into shaka-project:main Apr 9, 2024
21 of 22 checks passed
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 8, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancelling trick play at seekable ends requires too much accuracy
4 participants