Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(Cast): memoize/cache canDisplayType results to reduce startup latency #6367

Merged
merged 1 commit into from
Mar 26, 2024
Merged

perf(Cast): memoize/cache canDisplayType results to reduce startup latency #6367

merged 1 commit into from
Mar 26, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Mar 25, 2024 •
edited
Loading

Related to #5776 (comment)

@avelad avelad added type: performance A performance issue priority: P1 Big impact or workaround impractical; resolve before feature release platform: Cast Issues affecting Cast devices labels Mar 25, 2024
@avelad avelad added this to the v5.0 milestone Mar 25, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 83.33%

@avelad avelad merged commit 30285b2 into shaka-project:main Mar 26, 2024
23 checks passed
@shaka-bot shaka-bot mentioned this pull request Mar 26, 2024
Merged
@avelad avelad deleted the cache-canDisplayType branch March 26, 2024 06:39
avelad added a commit that referenced this pull request Apr 8, 2024
@avelad
perf(Cast): memoize/cache canDisplayType results to reduce startup la…
9870b48 
…tency (#6367)

Related to
#5776 (comment)
@shaka-bot shaka-bot mentioned this pull request Apr 8, 2024
Merged
avelad added a commit that referenced this pull request Apr 8, 2024
@avelad
perf(Cast): memoize/cache canDisplayType results to reduce startup la…
f54433e 
…tency (#6367)

Related to
#5776 (comment)
@shaka-bot shaka-bot mentioned this pull request Apr 8, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 25, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@JulianDomingo JulianDomingo Awaiting requested review from JulianDomingo

@theodab theodab Awaiting requested review from theodab

@alekzz alekzz Awaiting requested review from alekzz

Assignees
No one assigned
Labels
platform: Cast Issues affecting Cast devices priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: performance A performance issue
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @joeyparrish