Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Ads): Add ability to set tracking URL for Media Tailor #6365

Merged
merged 1 commit into from
Mar 27, 2024
Merged

feat(Ads): Add ability to set tracking URL for Media Tailor #6365

merged 1 commit into from
Mar 27, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Mar 25, 2024

Closes #6234

@avelad avelad mentioned this pull request Mar 25, 2024
Closed
@avelad avelad added type: enhancement New feature or request component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent labels Mar 25, 2024
@avelad avelad added this to the v5.0 milestone Mar 25, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 52.38%

@avelad avelad merged commit b51e661 into shaka-project:main Mar 27, 2024
21 checks passed
@shaka-bot shaka-bot mentioned this pull request Mar 27, 2024
Merged
@avelad avelad deleted the media-tailor-export branch March 27, 2024 06:37
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 26, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cristian-atehortua cristian-atehortua cristian-atehortua approved these changes

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

Export MediaTailorAdManager and add ability to set tracking URL
4 participants
@avelad @shaka-bot @theodab @cristian-atehortua