Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix playback stuck on initial gap #6340

Merged
merged 10 commits into from
Mar 14, 2024
Merged

fix: Fix playback stuck on initial gap #6340

merged 10 commits into from
Mar 14, 2024

Conversation

vlazh
Copy link
Contributor

@vlazh vlazh commented Mar 11, 2024

Fixes #6339

Copy link

google-cla bot commented Mar 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vlazh vlazh changed the title Skip the initial buffer gap fix: stuck on initial buffer gap Mar 11, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented Mar 11, 2024

Incremental code coverage: 100.00%

@joeyparrish joeyparrish changed the title fix: stuck on initial buffer gap fix: Fix playback stuck on initial gap Mar 12, 2024
@joeyparrish
Copy link
Member

@vlazh, thank you for the fix! Could you try to add a test for this? It would be nice to know right away if we ever reintroduced this bug in a future refactor.

Since the fix is in lib/player.js, it might be best to test for it in test/player_integration.js or test/player_unit.js. Let me know if you need any guidance on how to do that.

@vlazh
Copy link
Contributor Author

vlazh commented Mar 14, 2024

@joeyparrish could you review again?

@joeyparrish
Copy link
Member

I double-checked that the test fails with the fix commented out, so it is an effective test. Thanks!

@joeyparrish joeyparrish merged commit 292ef20 into shaka-project:main Mar 14, 2024
15 checks passed
avelad pushed a commit that referenced this pull request Apr 8, 2024
avelad pushed a commit that referenced this pull request Apr 8, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 13, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck on initial buffer gap (dash)
3 participants