-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix playback stuck on initial gap #6340
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Incremental code coverage: 100.00% |
@vlazh, thank you for the fix! Could you try to add a test for this? It would be nice to know right away if we ever reintroduced this bug in a future refactor. Since the fix is in lib/player.js, it might be best to test for it in test/player_integration.js or test/player_unit.js. Let me know if you need any guidance on how to do that. |
@joeyparrish could you review again? |
I double-checked that the test fails with the fix commented out, so it is an effective test. Thanks! |
Fixes #6339