feat(ABR): Additional request information for ABR Managers #6313
Conversation
|
Incremental code coverage: 100.00% |
| * @exportDoc | ||
| */ | ||
| segmentDownloaded(deltaTimeMs, numBytes, allowSwitch) {} | ||
| segmentDownloaded(deltaTimeMs, numBytes, allowSwitch, request) {} |
There was a problem hiding this comment.
I don't see this new parameter added to our default AbrManager or any test fakes.
There was a problem hiding this comment.
We are using a custom ABR manager and are experimenting with different algorithms and I didn't want to complicate or change the behaviour of the simple ABR manager.
There was a problem hiding this comment.
Can you explain the algorithm? Maybe can be interesting in Shaka…
There was a problem hiding this comment.
Its basically to mitigate the reasons outlined in this comment
The concept of min bytes is a problem when you get down to really low bandwidths.
There was a problem hiding this comment.
I don't see this new parameter added to our default AbrManager or any test fakes.
I didn't want to complicate or change the behaviour of the simple ABR manager.
You don't need to implement the behavior. Please just add the argument, so that the method signature of our builtins always agree with the external definition.
This PR makes the following request information available for ABR consideration. Allowing the ABR manager to know about the request latency from the time to first byte and knowing the order order of a packet, as well as the contentType of the request.