feat: Update for LCEVC Integration with new features added. #6263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added full screen support for LCEVC Decoder integration for iOS and also minor performance improvement changes.
|
Incremental code coverage: No instrumented code was changed. |
avelad
added
type: enhancement
joeyparrish
reviewed
Feb 21, 2024
We have migrated the logic for iOS fullscreen into the lcevc library which removes the need for any change to the shaka player library. We have updated the latest version on NPM and updated all the occurrences of version in readmes.
avelad
approved these changes
Apr 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features for LCEVC Decoder integration into Shaka player:
Initially in this PR we had changes to shaka player to accommodate changes for iOS fullscreen functionality. But now we have a way to do that inside the scope of lcevc decoder. So the only change in this PR is the version bump of the lcevc decoder library.