Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Include text bandwidth in stats #6109

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 16, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Jan 16, 2024
@avelad avelad added this to the v5.0 milestone Jan 16, 2024
Copy link
Member

@tykus160 tykus160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to add some unit test for this.

@avelad avelad requested a review from tykus160 January 16, 2024 12:14
@avelad avelad merged commit 4823dfe into shaka-project:main Jan 18, 2024
11 of 15 checks passed
@avelad avelad deleted the stats-text-bandwidth branch January 18, 2024 06:58
avelad added a commit that referenced this pull request Jan 18, 2024
avelad added a commit that referenced this pull request Jan 18, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 18, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants