Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): Fix the scrolling when scrolling from the laterals when seekOnTaps is enabled #6050

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 8, 2024

Fixes #6027

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Jan 8, 2024
@avelad avelad added this to the v5.0 milestone Jan 8, 2024
@avelad avelad requested a review from theodab January 8, 2024 14:58
@theodab
Copy link
Contributor

theodab commented Jan 9, 2024

Fixes #6027

In that issue you said this is a partial fix. If you marks this with "fixes", it'll auto-close the issue.

@avelad avelad merged commit df05692 into shaka-project:main Jan 9, 2024
15 of 19 checks passed
@avelad avelad deleted the tap-to-seek-fix branch January 9, 2024 08:43
avelad added a commit that referenced this pull request Jan 9, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 9, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI interactivity is using the wrong event listeners - really bad experience for mobile
3 participants