fix: APL set-top box wrongly identifies as an Apple device. #6026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tykus160
approved these changes
Dec 22, 2023
dave-nicholas
approved these changes
Dec 22, 2023
avelad
added
type: enhancement
avelad
approved these changes
Jan 8, 2024
|
@vvasylkovskyi Please fix the lint errors. Thanks! |
avelad
changed the title
avelad
added
type: bug
avelad
pushed a commit
that referenced
this pull request
Jan 8, 2024
avelad
pushed a commit
that referenced
this pull request
Jan 8, 2024
joeyparrish
pushed a commit
that referenced
this pull request
Feb 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simillar to this PR raised last year - #4310.
The APL devices also belong to Liberty Global and are Webkit-based. We noticed that these devices are being detected incorrectly as Apple -
Platform.isApple(), and as such, the source equalsshouldUseSrcEquals_is selected instead of MSE. The native playback is not working as expected, and MSE is preferred on these devices