perf: PeriodCombiner improvements #6005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 96.20% |
avelad
added
type: performance
avelad
approved these changes
Jan 8, 2024
avelad
pushed a commit
that referenced
this pull request
Jan 9, 2024
Summary of changes: - create dummy streams during preparing arrays of input streams - use hash map to quickly find perfect stream matches across periods - hash map also automatically removes duplicates, so remove previous logic for finding them - check earlier are we trying to create output stream from dummy stream - 2 changes from above also gives us a possibility to simplify `areCompatible()` & `isBetterMatch()` methods - reduce creation of spare collections when concatenating streams - reduce conditional logic when possible I was testing `PeriodCombiner.combinePeriods()` performance of mentioned changes on Tizen 2021 on 2 streams and I've got following results: | content | upstream | proposed changes | | - | -: | -: | | stream 1 | 23 ms | 17 ms | | stream 2 | 484 ms | 191 ms | Both streams are VOD. Stream 1 has 18 periods with 6 video & audio tracks in each. Stream 2 has 18 periods with 6 video tracks & 36 audio tracks in each.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
areCompatible()&isBetterMatch()methodsI was testing
PeriodCombiner.combinePeriods()performance of mentioned changes on Tizen 2021 on 2 streams and I've got following results:Both streams are VOD.
Stream 1 has 18 periods with 6 video & audio tracks in each.
Stream 2 has 18 periods with 6 video tracks & 36 audio tracks in each.