Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize animations for Chromecast #505

Closed
joeyparrish opened this issue Sep 1, 2016 · 2 comments
Closed

Optimize animations for Chromecast #505

joeyparrish opened this issue Sep 1, 2016 · 2 comments
Labels
platform: Cast Issues affecting Cast devices priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated status: will not implement The team chooses not to implement this enhancement type: enhancement New feature or request

Comments

@joeyparrish
Copy link
Member

The buffering spinner is today based on SVG + CSS3 animation. It appears to perform poorly on Chromecast. Visually, it is not animating smoothly.

I have tried a few alternatives, but it is not yet clear if the spinner itself is fully to blame. Before we go further on creating a new spinner, we should do a quantitative analysis of the performance issues we're seeing.

Here are some ideas here that may be useful once we have some baseline data:

The G+ post suggests that the idle card may influence performance even while hidden. The HTML5 Rocks article suggests that we should avoid animating colors. Both articles recommend against the use of shadows.

Here are some open-source CSS spinners: https://github.com/lukehaas/css-loaders
Many of these use shadows, but if we relax the author's single-div requirement, some of them can be done with background colors and transforms.

@joeyparrish joeyparrish added the type: enhancement New feature or request label Sep 1, 2016
@joeyparrish joeyparrish added this to the v2+ milestone Sep 1, 2016
@joeyparrish joeyparrish modified the milestones: v2+, v2.1.0 Oct 4, 2016
@joeyparrish joeyparrish modified the milestones: v2.1.0, Backlog Dec 13, 2016
@joeyparrish joeyparrish modified the milestones: Backlog, v2.2.0 Mar 31, 2017
@joeyparrish joeyparrish modified the milestones: v2.2.0, Backlog May 24, 2017
@joeyparrish joeyparrish added the flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this label Dec 4, 2017
@joeyparrish joeyparrish modified the milestones: Backlog, Backlog 2 Jan 28, 2020
@TheModMaker TheModMaker added the priority: P3 Useful but not urgent label Sep 29, 2021
@avelad avelad added the platform: Cast Issues affecting Cast devices label May 3, 2022
@avelad
Copy link
Member

avelad commented May 19, 2022

@joeyparrish I'm not sure we add it, since we want to do #4214 in the future

@joeyparrish
Copy link
Member Author

Fair. I think it's also somewhat better since this issue was originally filed 6 years ago. The spinner used to also change colors. :-)

@joeyparrish joeyparrish added status: will not implement The team chooses not to implement this enhancement and removed flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this labels May 23, 2022
@joeyparrish joeyparrish removed this from the Backlog milestone May 23, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: Cast Issues affecting Cast devices priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated status: will not implement The team chooses not to implement this enhancement type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants