Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hls): Fix av1 codec selection in HLS. #4203

Merged
merged 1 commit into from
May 9, 2022
Merged

fix(hls): Fix av1 codec selection in HLS. #4203

merged 1 commit into from
May 9, 2022

Conversation

wjywbs
Copy link
Contributor

@wjywbs wjywbs commented May 8, 2022 •
edited
Loading

Description

Also verified that DASH av1 playback already works.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist:

  • I have signed the Google CLA https://cla.developers.google.com
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have verified my change on multiple browsers on different platforms
  • I have run ./build/all.py and the build passes
  • I have run ./build/test.py and all tests pass

@avelad avelad self-requested a review May 8, 2022 07:39
@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format labels May 8, 2022
@avelad avelad added this to the v4.1 milestone May 8, 2022
@avelad avelad merged commit 5e13495 into shaka-project:main May 9, 2022
@github-actions github-actions bot mentioned this pull request May 9, 2022
Closed
@github-actions github-actions bot mentioned this pull request May 17, 2022
Merged
joeyparrish pushed a commit that referenced this pull request May 17, 2022
@wjywbs @joeyparrish
fix(hls): Fix av1 codec selection in HLS. (#4203)
c72ac92
@github-actions github-actions bot mentioned this pull request May 17, 2022
Merged
joeyparrish pushed a commit that referenced this pull request May 17, 2022
@wjywbs @joeyparrish
fix(hls): Fix av1 codec selection in HLS. (#4203)
e493a56
@github-actions github-actions bot mentioned this pull request May 17, 2022
Merged
joeyparrish pushed a commit that referenced this pull request May 17, 2022
@wjywbs @joeyparrish
fix(hls): Fix av1 codec selection in HLS. (#4203)
4d418be
@github-actions github-actions bot mentioned this pull request May 17, 2022
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad approved these changes

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@wjywbs @avelad