Fix TTML - font-size is not applied in nested cues #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
theodab
requested changes
Jan 12, 2022
theodab
approved these changes
Jan 12, 2022
|
I'm not "authorized" to merge this pull request, huh. |
|
Sorry, the new settings clearly need some work. Let me see if I can fix it. |
|
@theodab, see if you can do it now. I think I fixed the settings. |
|
Thanks, that worked. |
joeyparrish
pushed a commit
that referenced
this pull request
Jan 28, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Jan 28, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Jan 28, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3743