Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dimensions of CS Ad are wrong after the first pre roll. #3638

Closed
avelad opened this issue Sep 16, 2021 · 1 comment · Fixed by #3652
Closed

Dimensions of CS Ad are wrong after the first pre roll. #3638

avelad opened this issue Sep 16, 2021 · 1 comment · Fixed by #3652
Assignees
@avelad
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.3

Comments

@avelad
Copy link
Member

avelad commented Sep 16, 2021

Have you read the FAQ and checked for duplicate open issues? Yes

What version of Shaka Player are you using? 3.2.0

Can you reproduce the issue with our latest release version? Yes

Can you reproduce the issue with the latest code from master? Yes

Are you using the demo app or your own custom app? Demo App

If custom app, can you reproduce the issue using our demo app? Yes

What browser and OS are you using? Chrome 93 macOS 11.5.2

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?

They are the video of the demo, in the video I have recorded you can see it.

What did you do?

cs-dimensions.mov

What did you expect to happen?
Dimensions are correct

What actually happened?

Dimensions aren't correct
@theodab theodab added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent and removed needs triage labels Sep 16, 2021
@theodab
Copy link
Contributor

theodab commented Sep 16, 2021

Reproduced. Thanks for the report.
This particular bug feels super familiar. I could have sworn I've looked into it before, but it might just be my memory playing tricks on me...

@shaka-bot shaka-bot added this to the v3.3 milestone Sep 16, 2021
@avelad avelad mentioned this issue Sep 20, 2021
Merged
theodab pushed a commit that referenced this issue Sep 22, 2021
fix(ads): Add ResizeObserver to CS ad manager. (#3652)
2bdc326 
Closes: #3638
joeyparrish pushed a commit that referenced this issue Oct 12, 2021
@joeyparrish
fix(ads): Add ResizeObserver to CS ad manager. (#3652)
60188c0 
Closes: #3638
joeyparrish pushed a commit that referenced this issue Oct 12, 2021
@joeyparrish
fix(ads): Add ResizeObserver to CS ad manager. (#3652)
423aff6 
Closes: #3638
joeyparrish pushed a commit that referenced this issue Oct 12, 2021
@joeyparrish
fix(ads): Add ResizeObserver to CS ad manager. (#3652)
6a2b02a 
Closes: #3638
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 21, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@avelad avelad

Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.3
Development

Successfully merging a pull request may close this issue.

Fix: dimensions of CS Ad are wrong after the first pre roll. avelad/shaka-player
3 participants
@avelad @shaka-bot @theodab