-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support xlink:actuate=“onRequest” #3238
Comments
We may need to do something similar to handle HLS interstitial support. We will be investigating the work soon, but may take a while to implement. This will require major reworks to implement. |
Corresponding HLS interstitial feature: #3364 |
Hi, I was wondering if you could share anything about how the discussions with Zach Cava are progressing on this? We are hoping to capitalize on support for SGAI in early/mid 2022 in ShakaPlayer. Would that be a realistic expectation to have? |
Hey Team, |
@ronak2121 I can see XLink on Request is not supported yet on Shaka Player |
I am not aware of anyone working on either patch manifests or xlink onRequest. Today xlinks are only resolved immediately on parsing the manifest. |
@Gheri we aren't doing SGAI yet. We're still on CSAI with Google IMA. I am super motivated to add this support though. I will hit you up @joeyparrish when we're ready to start contributing and get some pointers. |
@avelad is this being actually being considered to be added in version 4.1? @joeyparrish if you still need help implementing this and/or HLS Interstitials, we are open to help you. Can you describe the next steps? |
As far as I can tell, nobody is working on this yet, so it shouldn't be in the v4.1 milestone. I placed this enhancement in the backlog for now. As for next steps, the original post describes what look like several separate requests:
I would say that the next steps depend on which of these you intend to tackle first:
|
@ronak2121 Did you guys know whats equivalent of xlink onRequest in HLS ?? Becuase HLS interstitial is loading the manifest on load and not on Request ?? |
@Gheri there's no such thing as xlinks for HLS. Look at the new HLS talks from Apple about how things work there. I have successfully prototyped SGAI on HLS with iOS using AVPlayer, and it works as advertised with delayed resolution. |
HLS interstitials are now available in the nightly demo, DASH patches are supported since version 4.9, and we also support integrated ID3 in EMSG. |
Hi @avelad, what do you mean exactly by your previous post? Do you mean ShakaPlayer now supports onRequest xlink resolution? DASH patches is the SGAI solution for live streams, not VOD. |
@ronak2121 I have updated the title of the issue to reflect the part that remains to be integrated and that we will follow up on in this issue. |
Have you read the FAQ and checked for duplicate open issues?
Yes
Is your feature request related to a problem? Please describe.
We are integrating with Ads, and would prefer to use DASH-IF's latest SGAI specifications that allows us to delay filling the Ad Pods while reusing the player heuristics to maintain Quality of Service. Please see: https://dashif.org/docs/CR-Ad-Insertion-r8.pdf and https://drive.google.com/file/d/1TwSuMGa1gfesdWBvlbK1rHLNVwiZNX3l/view for more information. I've asked questions out to the DASH-IF forum about impact to the player timeline (amongst others): Dash-Industry-Forum/AdInsertion#83
Describe the solution you'd like
Describe alternatives you've considered
We are using CSAI to workaround this limitation, but would prefer to use SGAI to capitalize on the player qos calculations to maintain qos on low bandwidth connections.
The text was updated successfully, but these errors were encountered: