Skip to content

Commit 6783ce0

Browse files
authored
feat(Ads): Expose the interstitial player (#7793)
Close #7763
1 parent 6abdec4 commit 6783ce0

File tree

4 files changed

+28
-2
lines changed

4 files changed

+28
-2
lines changed

externs/shaka/ads.js

+5
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,11 @@ shaka.extern.IAdManager = class extends EventTarget {
305305
* @return {!Promise}
306306
*/
307307
addAdUrlInterstitial(url) {}
308+
309+
/**
310+
* @return {shaka.Player}
311+
*/
312+
getInterstitialPlayer() {}
308313
};
309314

310315

lib/ads/ad_manager.js

+14
Original file line numberDiff line numberDiff line change
@@ -893,6 +893,20 @@ shaka.ads.AdManager = class extends shaka.util.FakeEventTarget {
893893
return this.interstitialAdManager_.addAdUrlInterstitial(url);
894894
}
895895

896+
/**
897+
* @override
898+
* @export
899+
*/
900+
getInterstitialPlayer() {
901+
if (!this.interstitialAdManager_) {
902+
throw new shaka.util.Error(
903+
shaka.util.Error.Severity.RECOVERABLE,
904+
shaka.util.Error.Category.ADS,
905+
shaka.util.Error.Code.INTERSTITIAL_AD_MANAGER_NOT_INITIALIZED);
906+
}
907+
return this.interstitialAdManager_.getPlayer();
908+
}
909+
896910
/**
897911
* @param {!shaka.util.FakeEvent} event
898912
* @private

lib/ads/interstitial_ad_manager.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,12 @@ shaka.ads.InterstitialAdManager = class {
299299
this.player_.destroy();
300300
}
301301

302+
/**
303+
* @return {shaka.Player}
304+
*/
305+
getPlayer() {
306+
return this.player_;
307+
}
302308

303309
/**
304310
* @param {shaka.extern.HLSInterstitial} hlsInterstitial
@@ -1352,8 +1358,6 @@ shaka.ads.InterstitialAdManager = class {
13521358
this.player_.configure('ads.disableDASHInterstitial', true);
13531359
const netEngine = this.player_.getNetworkingEngine();
13541360
goog.asserts.assert(netEngine, 'Need networking engine');
1355-
netEngine.clearAllRequestFilters();
1356-
netEngine.clearAllResponseFilters();
13571361
this.basePlayer_.getNetworkingEngine().copyFiltersInto(netEngine);
13581362
}
13591363

test/test/util/fake_ad_manager.js

+3
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,9 @@ shaka.test.FakeAdManager = class extends shaka.util.FakeEventTarget {
103103
/** @override */
104104
addAdUrlInterstitial(url) {}
105105

106+
/** @override */
107+
getInterstitialPlayer() {}
108+
106109
/**
107110
* @param {!shaka.test.FakeAd} ad
108111
*/

0 commit comments

Comments
 (0)