feat(Ads): Allow OverlayEvents without viewport (#7734)

Author: avelad

lib/ads/interstitial_ad_manager.js

@@ -379,60 +379,72 @@ shaka.ads.InterstitialAdManager = class {
       return;
     }
 
-    const viewport = TXml.findChild(overlayEvent, 'Viewport');
-    const topLeft = TXml.findChild(overlayEvent, 'TopLeft');
-    const size = TXml.findChild(overlayEvent, 'Size');
-    if (!viewport || !topLeft || !size) {
-      shaka.log.warning('Unsupported OverlayEvent', region);
-      return;
-    }
-    const viewportX = TXml.parseAttr(viewport, 'x', TXml.parseInt);
-    if (viewportX == null) {
-      shaka.log.warning('Unsupported OverlayEvent', region);
-      return;
-    }
-    const viewportY = TXml.parseAttr(viewport, 'y', TXml.parseInt);
-    if (viewportY == null) {
-      shaka.log.warning('Unsupported OverlayEvent', region);
-      return;
-    }
-    const topLeftX = TXml.parseAttr(topLeft, 'x', TXml.parseInt);
-    if (topLeftX == null) {
-      shaka.log.warning('Unsupported OverlayEvent', region);
-      return;
-    }
-    const topLeftY = TXml.parseAttr(topLeft, 'y', TXml.parseInt);
-    if (topLeftY == null) {
-      shaka.log.warning('Unsupported OverlayEvent', region);
-      return;
-    }
-    const sizeX = TXml.parseAttr(size, 'x', TXml.parseInt);
-    if (sizeX == null) {
-      shaka.log.warning('Unsupported OverlayEvent', region);
-      return;
-    }
-    const sizeY = TXml.parseAttr(size, 'y', TXml.parseInt);
-    if (sizeY == null) {
-      shaka.log.warning('Unsupported OverlayEvent', region);
-      return;
-    }
-
     /** @type {!shaka.extern.AdInterstitialOverlay} */
-    const overlay = {
+    let overlay = {
       viewport: {
-        x: viewportX,
-        y: viewportY,
+        x: 1920,
+        y: 1080,
       },
       topLeft: {
-        x: topLeftX,
-        y: topLeftY,
+        x: 0,
+        y: 0,
       },
       size: {
-        x: sizeX,
-        y: sizeY,
+        x: 1920,
+        y: 1080,
       },
     };
 
+    const viewport = TXml.findChild(overlayEvent, 'Viewport');
+    const topLeft = TXml.findChild(overlayEvent, 'TopLeft');
+    const size = TXml.findChild(overlayEvent, 'Size');
+    if (viewport && topLeft && size) {
+      const viewportX = TXml.parseAttr(viewport, 'x', TXml.parseInt);
+      if (viewportX == null) {
+        shaka.log.warning('Unsupported OverlayEvent', region);
+        return;
+      }
+      const viewportY = TXml.parseAttr(viewport, 'y', TXml.parseInt);
+      if (viewportY == null) {
+        shaka.log.warning('Unsupported OverlayEvent', region);
+        return;
+      }
+      const topLeftX = TXml.parseAttr(topLeft, 'x', TXml.parseInt);
+      if (topLeftX == null) {
+        shaka.log.warning('Unsupported OverlayEvent', region);
+        return;
+      }
+      const topLeftY = TXml.parseAttr(topLeft, 'y', TXml.parseInt);
+      if (topLeftY == null) {
+        shaka.log.warning('Unsupported OverlayEvent', region);
+        return;
+      }
+      const sizeX = TXml.parseAttr(size, 'x', TXml.parseInt);
+      if (sizeX == null) {
+        shaka.log.warning('Unsupported OverlayEvent', region);
+        return;
+      }
+      const sizeY = TXml.parseAttr(size, 'y', TXml.parseInt);
+      if (sizeY == null) {
+        shaka.log.warning('Unsupported OverlayEvent', region);
+        return;
+      }
+      overlay = {
+        viewport: {
+          x: viewportX,
+          y: viewportY,
+        },
+        topLeft: {
+          x: topLeftX,
+          y: topLeftY,
+        },
+        size: {
+          x: sizeX,
+          y: sizeY,
+        },
+      };
+    }
+
     /** @type {!shaka.extern.AdInterstitial} */
     const interstitial = {
       id: region.id,