Which USE_* features are obsolete and can be removed (or unconditionally enabled)?

[alejandro-colomar]

Hi!

The other day we were discussing that it might be good to remove USE_SYSLOG (although I'm not sure if the code it enables should be then unconditionally enabled or simply removed). Which others can also be simplified?

I'd like to get rid of most of that preprocessor stuff in one way or another.

Cheers,
Alex

[ikerexxe]

I'd also add USE_NSCD and USE_UTMPX to that list.

[ikerexxe]

I was reviewing #609 and I saw SHADOWGRP and HAVE_SHADOWGRP. I know they aren't USE_* macros but it could be interesting to remove that also (or at least investigate it).

[zeha]

!HAVE_LCKPWDF also seems like it could go away.

[zeha]

TBF the code would become a lot simpler to read if !HAVE_PAM was gone, but I guess some distros don't like that.

[alejandro-colomar]

Since nobody has commented on this, I'll remove !HAVE_LCKPWDF for 4.18.

[alejandro-colomar]

I was reviewing #609 and I saw SHADOWGRP and HAVE_SHADOWGRP. I know they aren't USE_* macros but it could be interesting to remove that also (or at least investigate it).

I have a PR related to that:

• configure.ac, lib/, src/: Presume working shadow group support in libc #1111

I still didn't remove that, but I simplified it a little bit.