From e96601ef094c1035e9f3ce317c116d6c5c27e2b8 Mon Sep 17 00:00:00 2001 From: Yong He Date: Wed, 11 Jun 2025 13:33:27 -0700 Subject: [PATCH 1/4] Diagnose on use of struct inheritance. --- source/slang/slang-check-decl.cpp | 24 ++++++++++++++++++++++-- source/slang/slang-diagnostic-defs.h | 11 ++++++++--- tests/diagnostics/inheritance-1.slang | 13 +++++++++++++ tests/diagnostics/inheritance-2.slang | 10 ++++++++++ 4 files changed, 53 insertions(+), 5 deletions(-) create mode 100644 tests/diagnostics/inheritance-1.slang create mode 100644 tests/diagnostics/inheritance-2.slang diff --git a/source/slang/slang-check-decl.cpp b/source/slang/slang-check-decl.cpp index 2865188b4db..ddc4ec4d5c9 100644 --- a/source/slang/slang-check-decl.cpp +++ b/source/slang/slang-check-decl.cpp @@ -7811,7 +7811,7 @@ void SemanticsDeclBasesVisitor::visitStructDecl(StructDecl* decl) { getSink()->diagnose( inheritanceDecl, - Diagnostics::baseOfStructMustBeStructOrInterface, + Diagnostics::baseOfStructMustBeInterface, decl, baseType); continue; @@ -7823,6 +7823,26 @@ void SemanticsDeclBasesVisitor::visitStructDecl(StructDecl* decl) } else if (auto baseStructDeclRef = baseDeclRef.as()) { + if (!isFromCoreModule(decl)) + { + // In Slang 2026, we no longer allow structs to inherit from other structs. + if (isSlang2026OrLater(this)) + { + getSink()->diagnose( + inheritanceDecl, + Diagnostics::baseOfStructMustBeInterface, + decl, + baseType); + } + else + { + // For legacy langauge versions, we still allow struct inheritance to avoid + // breaking existing code, but we will emit a warning to inform the user + // that this feature is unstable and may be removed in the future. + getSink()->diagnose(inheritanceDecl, Diagnostics::inheritanceUnstable); + } + } + // To simplify the task of reading and maintaining code, // we require that when a `struct` inherits from another // `struct`, the base `struct` is the first item in @@ -7845,7 +7865,7 @@ void SemanticsDeclBasesVisitor::visitStructDecl(StructDecl* decl) { getSink()->diagnose( inheritanceDecl, - Diagnostics::baseOfStructMustBeStructOrInterface, + Diagnostics::baseOfStructMustBeInterface, decl, baseType); continue; diff --git a/source/slang/slang-diagnostic-defs.h b/source/slang/slang-diagnostic-defs.h index f4741ab048c..4f0edf53b34 100644 --- a/source/slang/slang-diagnostic-defs.h +++ b/source/slang/slang-diagnostic-defs.h @@ -1662,8 +1662,8 @@ DIAGNOSTIC( DIAGNOSTIC( 30811, Error, - baseOfStructMustBeStructOrInterface, - "struct '$0' cannot inherit from type '$1' that is neither a struct nor an interface") + baseOfStructMustBeInterface, + "struct '$0' cannot inherit from non-interface type '$1'") DIAGNOSTIC( 30812, Error, @@ -1681,7 +1681,12 @@ DIAGNOSTIC( baseOfClassMustBeClassOrInterface, "class '$0' cannot inherit from type '$1' that is neither a class nor an interface") DIAGNOSTIC(30815, Error, circularityInExtension, "circular extension is not allowed.") - +DIAGNOSTIC( + 30816, + Warning, + inheritanceUnstable, + "support for inheritance is unstable and will be removed in future language versions, consider " + "using composition instead.") DIAGNOSTIC( 30820, Error, diff --git a/tests/diagnostics/inheritance-1.slang b/tests/diagnostics/inheritance-1.slang new file mode 100644 index 00000000000..c811623d88f --- /dev/null +++ b/tests/diagnostics/inheritance-1.slang @@ -0,0 +1,13 @@ +//DIAGNOSTIC_TEST:SIMPLE(filecheck=CHECK): + +// Tests that we will diagnose a warning on struct inheritance being unstable +// before Slang 2026. + +#lang 2025 + +struct Base {} + +//CHECK: ([[# @LINE+1]]): warning 30816: +struct Derived : Base {} + +struct Base1 {} \ No newline at end of file diff --git a/tests/diagnostics/inheritance-2.slang b/tests/diagnostics/inheritance-2.slang new file mode 100644 index 00000000000..6b1bcfaffbb --- /dev/null +++ b/tests/diagnostics/inheritance-2.slang @@ -0,0 +1,10 @@ +//DIAGNOSTIC_TEST:SIMPLE(filecheck=CHECK): + +// Tests that we will diagnose an error on struct inheritance in language 2026 or later. + +#lang 2026 + +struct Base {} + +//CHECK: ([[# @LINE+1]]): error 30811: +struct Derived : Base {} From ce3e228ad47aaa4872a5ae363a202602c0031954 Mon Sep 17 00:00:00 2001 From: Yong He Date: Wed, 11 Jun 2025 14:07:39 -0700 Subject: [PATCH 2/4] fix test. --- tests/hlsl-intrinsic/size-of/size-of.slang | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/hlsl-intrinsic/size-of/size-of.slang b/tests/hlsl-intrinsic/size-of/size-of.slang index fc531bc4eff..965e0a4e5af 100644 --- a/tests/hlsl-intrinsic/size-of/size-of.slang +++ b/tests/hlsl-intrinsic/size-of/size-of.slang @@ -1,3 +1,4 @@ +#pragma warning(disable:30816) //TEST(compute):COMPARE_COMPUTE_EX:-cpu -compute -shaderobj //TEST(compute):COMPARE_COMPUTE_EX:-slang -compute -shaderobj From 5f069de983c799fef23edf96a474b5004907df03 Mon Sep 17 00:00:00 2001 From: Yong He Date: Wed, 11 Jun 2025 16:31:21 -0700 Subject: [PATCH 3/4] Fix tests. --- tests/hlsl-intrinsic/size-of/align-of.slang | 2 ++ tests/initializer-list/struct-inherit.slang | 2 ++ .../inheritance/derived-struct-init-list.slang | 2 ++ .../inheritance/struct-inherit-interface-requirement.slang | 1 + .../inheritance/struct-inheritance-imported.slang | 2 +- tests/language-feature/inheritance/struct-inheritance.slang | 2 ++ .../initializer-lists/inheritance-generic.slang | 3 +++ .../struct-field-initializer-extension-inheritance.slang | 2 ++ .../struct-field-initializer-extension.slang | 1 + .../struct-field-initializer-inherited-chain.slang | 3 +++ ...ruct-field-initializer-init-inheritance-write-to-same.slang | 3 +++ .../struct-field-initializer-static.slang | 3 +++ 12 files changed, 25 insertions(+), 1 deletion(-) diff --git a/tests/hlsl-intrinsic/size-of/align-of.slang b/tests/hlsl-intrinsic/size-of/align-of.slang index c5be345c8ca..537949375d0 100644 --- a/tests/hlsl-intrinsic/size-of/align-of.slang +++ b/tests/hlsl-intrinsic/size-of/align-of.slang @@ -7,6 +7,8 @@ //TEST_INPUT:ubuffer(data=[0 0 0 0], stride=4):out,name outputBuffer +#pragma warning(disable:30816) + RWStructuredBuffer outputBuffer; enum Enum : int8_t diff --git a/tests/initializer-list/struct-inherit.slang b/tests/initializer-list/struct-inherit.slang index 71487a74f87..642fb8f5447 100644 --- a/tests/initializer-list/struct-inherit.slang +++ b/tests/initializer-list/struct-inherit.slang @@ -3,6 +3,8 @@ //TEST(compute, vulkan):COMPARE_COMPUTE(filecheck-buffer=BUF):-cpu -compute -entry computeMain //TEST(smoke,compute):COMPARE_COMPUTE(filecheck-buffer=BUF):-dx12 -use-dxil -compute -entry computeMain +#pragma warning(disable:30816) + //TEST_INPUT:ubuffer(data=[0], stride=4):out,name=outputBuffer RWStructuredBuffer outputBuffer; diff --git a/tests/language-feature/inheritance/derived-struct-init-list.slang b/tests/language-feature/inheritance/derived-struct-init-list.slang index 51d3a9b6dee..213e5ee8e60 100644 --- a/tests/language-feature/inheritance/derived-struct-init-list.slang +++ b/tests/language-feature/inheritance/derived-struct-init-list.slang @@ -7,6 +7,8 @@ // an empty initializer list) is still possible // when using `struct` inheritance. +#pragma warning(disable:30816) + struct Base { int a = 1; diff --git a/tests/language-feature/inheritance/struct-inherit-interface-requirement.slang b/tests/language-feature/inheritance/struct-inherit-interface-requirement.slang index 84446aec30a..c6d30ed911f 100644 --- a/tests/language-feature/inheritance/struct-inherit-interface-requirement.slang +++ b/tests/language-feature/inheritance/struct-inherit-interface-requirement.slang @@ -5,6 +5,7 @@ // Test that a `struct` type can use an inherited // member to satisfy an interface requirement. +#pragma warning(disable:30816) interface ITweak { diff --git a/tests/language-feature/inheritance/struct-inheritance-imported.slang b/tests/language-feature/inheritance/struct-inheritance-imported.slang index 16816ec971f..b3399eaeb17 100644 --- a/tests/language-feature/inheritance/struct-inheritance-imported.slang +++ b/tests/language-feature/inheritance/struct-inheritance-imported.slang @@ -1,6 +1,6 @@ //TEST_IGNORE_FILE: // struct-inheritance-imported.slang - +#pragma warning(disable:30816) public struct Base { public int a; diff --git a/tests/language-feature/inheritance/struct-inheritance.slang b/tests/language-feature/inheritance/struct-inheritance.slang index d1611ddfc13..046a3f6b260 100644 --- a/tests/language-feature/inheritance/struct-inheritance.slang +++ b/tests/language-feature/inheritance/struct-inheritance.slang @@ -6,6 +6,8 @@ // Test that we can define a `struct` type // that inherits from another `struct`. +#pragma warning(disable:30816) + struct Base { int a; diff --git a/tests/language-feature/initializer-lists/inheritance-generic.slang b/tests/language-feature/initializer-lists/inheritance-generic.slang index d5b923afe48..71de21c4794 100644 --- a/tests/language-feature/initializer-lists/inheritance-generic.slang +++ b/tests/language-feature/initializer-lists/inheritance-generic.slang @@ -1,6 +1,9 @@ //TEST(compute):COMPARE_COMPUTE(filecheck-buffer=BUFFER):-shaderobj -vk //TEST(compute):COMPARE_COMPUTE(filecheck-buffer=BUFFER):-shaderobj +#pragma warning(disable:30816) + + struct Base { int a = 1; diff --git a/tests/language-feature/struct-field-initializers/struct-field-initializer-extension-inheritance.slang b/tests/language-feature/struct-field-initializers/struct-field-initializer-extension-inheritance.slang index 4af5f284772..47858e59ce9 100644 --- a/tests/language-feature/struct-field-initializers/struct-field-initializer-extension-inheritance.slang +++ b/tests/language-feature/struct-field-initializers/struct-field-initializer-extension-inheritance.slang @@ -1,6 +1,8 @@ //TEST:SIMPLE(filecheck=CHECK): -target hlsl -stage compute -entry computeMain RWStructuredBuffer outputBuffer; +#pragma warning(disable:30816) + //CHECK: error 30851 struct DefaultStructNoInit_base diff --git a/tests/language-feature/struct-field-initializers/struct-field-initializer-extension.slang b/tests/language-feature/struct-field-initializers/struct-field-initializer-extension.slang index 1acfeeba7f1..e5da60492c8 100644 --- a/tests/language-feature/struct-field-initializers/struct-field-initializer-extension.slang +++ b/tests/language-feature/struct-field-initializers/struct-field-initializer-extension.slang @@ -1,6 +1,7 @@ //TEST:SIMPLE(filecheck=CHECK): -target hlsl -stage compute -entry computeMain RWStructuredBuffer outputBuffer; + //CHECK: error 30851 struct DefaultStructNoInit diff --git a/tests/language-feature/struct-field-initializers/struct-field-initializer-inherited-chain.slang b/tests/language-feature/struct-field-initializers/struct-field-initializer-inherited-chain.slang index e6f856a2120..c1de40b3c4b 100644 --- a/tests/language-feature/struct-field-initializers/struct-field-initializer-inherited-chain.slang +++ b/tests/language-feature/struct-field-initializers/struct-field-initializer-inherited-chain.slang @@ -3,6 +3,9 @@ //TEST(compute, vulkan):COMPARE_COMPUTE(filecheck-buffer=BUF):-cpu -compute -entry computeMain //TEST(smoke,compute):COMPARE_COMPUTE(filecheck-buffer=BUF):-dx12 -use-dxil -compute -entry computeMain +#pragma warning(disable:30816) + + //TEST_INPUT:ubuffer(data=[0], stride=4):out,name=outputBuffer RWStructuredBuffer outputBuffer; diff --git a/tests/language-feature/struct-field-initializers/struct-field-initializer-init-inheritance-write-to-same.slang b/tests/language-feature/struct-field-initializers/struct-field-initializer-init-inheritance-write-to-same.slang index eff3595f1ce..e11379cf351 100644 --- a/tests/language-feature/struct-field-initializers/struct-field-initializer-init-inheritance-write-to-same.slang +++ b/tests/language-feature/struct-field-initializers/struct-field-initializer-init-inheritance-write-to-same.slang @@ -3,6 +3,9 @@ //TEST(compute, vulkan):COMPARE_COMPUTE(filecheck-buffer=BUF):-cpu -compute -entry computeMain //TEST(smoke,compute):COMPARE_COMPUTE(filecheck-buffer=BUF):-dx12 -use-dxil -compute -entry computeMain +#pragma warning(disable:30816) + + //TEST_INPUT:ubuffer(data=[0 0], stride=4):out,name=outputBuffer RWStructuredBuffer outputBuffer; diff --git a/tests/language-feature/struct-field-initializers/struct-field-initializer-static.slang b/tests/language-feature/struct-field-initializers/struct-field-initializer-static.slang index d6f9d36120d..97ebce04e8f 100644 --- a/tests/language-feature/struct-field-initializers/struct-field-initializer-static.slang +++ b/tests/language-feature/struct-field-initializers/struct-field-initializer-static.slang @@ -3,6 +3,9 @@ //TEST(compute, vulkan):COMPARE_COMPUTE(filecheck-buffer=BUF):-cpu -compute -entry computeMain //TEST(smoke,compute):COMPARE_COMPUTE(filecheck-buffer=BUF):-dx12 -use-dxil -compute -entry computeMain +#pragma warning(disable:30816) + + //TEST_INPUT:ubuffer(data=[0], stride=4):out,name=outputBuffer RWStructuredBuffer outputBuffer; From b12a0d64c7f92d49483add697f913b29ea76b356 Mon Sep 17 00:00:00 2001 From: Yong He Date: Wed, 11 Jun 2025 16:32:46 -0700 Subject: [PATCH 4/4] fix. --- .../struct-field-initializer-extension.slang | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/language-feature/struct-field-initializers/struct-field-initializer-extension.slang b/tests/language-feature/struct-field-initializers/struct-field-initializer-extension.slang index e5da60492c8..1acfeeba7f1 100644 --- a/tests/language-feature/struct-field-initializers/struct-field-initializer-extension.slang +++ b/tests/language-feature/struct-field-initializers/struct-field-initializer-extension.slang @@ -1,7 +1,6 @@ //TEST:SIMPLE(filecheck=CHECK): -target hlsl -stage compute -entry computeMain RWStructuredBuffer outputBuffer; - //CHECK: error 30851 struct DefaultStructNoInit