Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): use slash for alpha values in colors #681

Merged
merged 6 commits into from
Jun 24, 2023

Conversation

dan5py
Copy link
Contributor

@dan5py dan5py commented Jun 23, 2023

Fixes #678

@vercel
Copy link

vercel bot commented Jun 23, 2023

@dan5py is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice catch. My bad! I'll review and merge.

@vercel
Copy link

vercel bot commented Jun 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-template ⬜️ Ignored (Inspect) Jun 24, 2023 4:05pm
ui ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2023 4:05pm

@dan5py
Copy link
Contributor Author

dan5py commented Jun 23, 2023

@shadcn my bad, forgot the test file

@@ -64,7 +64,7 @@ describe("apply color mapping", async () => {
input:
"text-destructive border-destructive/50 dark:border-destructive [&>svg]:text-destructive text-destructive",
output:
"text-red-500 border-red-500:50 dark:border-red-500 [&>svg]:text-red-500 text-red-500 dark:text-red-900 dark:border-red-900:50 dark:dark:border-red-900 dark:[&>svg]:text-red-900 dark:text-red-900",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh man! I even got this wrong in the test file 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happens 😄

@shadcn shadcn merged commit 1971fa7 into shadcn-ui:main Jun 24, 2023
7 of 8 checks passed
@dan5py dan5py deleted the fix/issue-678 branch June 24, 2023 16:10
suleymanbariseser pushed a commit to suleymanbariseser/shadcn-ui that referenced this pull request Jul 25, 2023
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: CSS classnames opacity is not valid tailwind formatting
2 participants