(fix) - input(inputProps) @typescript-eslint/no-empty-interface #4082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An interface declaring no members is equivalent to its supertype.eslint@typescript-eslint/no-empty-interface
|
@argcast is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
2 tasks
imcodingideas
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4083
An interface declaring no members is equivalent to its supertype.eslint@typescript-eslint/no-empty-interface.
The issue in the code is due to the
InputPropsinterface extendingReact.InputHTMLAttributes<HTMLInputElement>without adding any new members. This is flagged by the ESLint rule @typescript-eslint/no-empty-interface, which indicates that an interface declaring no members is equivalent to its supertype.By changing the InputProps interface to a type alias:
export type InputProps = React.InputHTMLAttribute <HTMLInputElement>By using a type alias instead of an interface, the code directly assigns InputProps to
React.InputHTMLAttributes<HTMLInputElement>and avoids the ESLint warning about empty interfaces, as the type alias does not have the same issue.