Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listed branches should include MR numbers if present #95

Open
rootwork opened this issue Jun 29, 2022 · 0 comments
Open

Listed branches should include MR numbers if present #95

rootwork opened this issue Jun 29, 2022 · 0 comments

Comments

@rootwork
Copy link

Is your feature request related to a problem? Please describe

I was recently reviewing an issue that was hundreds of comments long and had two current MRs (for different versions of Drupal). When I clicked the extension button and read the list of branches, none of the ones listed seemed to correspond to the two MRs, because all I could see (in the comments at the bottom of a long comment thread) were the MR numbers.

Subsequently I realized that if I scrolled to the top of the issue I could see which branch names the MR numbers corresponded to. But this a) took some discovery and was not obvious, b) introduces friction especially on a long comment thread, and c) introduces the potential for error if there are multiple simultaneous MRs (as there were in this case) along with outdated MRs, each with different names.

Describe the solution you'd like

Prepend or append the MR number to the name of each branch listed. I also might suggest adding the term "MR" or "merge request" somewhere alongside "branch", as initially I wasn't even sure if that was where I should look for the MRs.

Describe alternatives you've considered

Listing MR numbers instead of names, which would be fine for reviewing but might make it harder if one were running git commands locally when actually working on an issue. So I think having both listed is better.

Additional context

This was the issue in question: https://www.drupal.org/project/drupal/issues/3085219

A third branch is also listed in the issue drop-down, named "undefined". I'm not sure what that is (there are two old branches/MRs, but they both have names).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant