Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix timepicker test fail at 12am/pm in 12 hour format #94

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

prateekshourya29
Copy link
Contributor

PR Details

Description

  • Fix TimePicker test fail at 12am/pm because hours array at index 12 is now null since hours array at index 0 is 12

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prateekshourya29 prateekshourya29 changed the title 🐛 Fix timepicker test fail at 12am/pm in 12 hour format 🐛 Fix timepicker test fail at 12am/pm in 12 hour format Jun 2, 2021
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #94 (c1bbbee) into master (34c0b38) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   80.76%   80.76%           
=======================================
  Files         140      140           
  Lines        2178     2178           
  Branches      535      535           
=======================================
  Hits         1759     1759           
  Misses        417      417           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c0b38...c1bbbee. Read the comment docs.

@anitnilay20 anitnilay20 merged commit 0c82476 into master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants