Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Test cases for Modal #85

Merged
merged 1 commit into from
May 29, 2021
Merged

🧪 Test cases for Modal #85

merged 1 commit into from
May 29, 2021

Conversation

prateekshourya29
Copy link
Contributor

PR Details

Description

Add test case for the modal component.

Related Issue

#39

Motivation and Context

For 100% test coverage.

How Has This Been Tested

Tested using jest with the help of react testing library.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 29, 2021

Codecov Report

Merging #85 (afd7900) into master (1c06818) will increase coverage by 1.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   73.32%   74.61%   +1.29%     
==========================================
  Files         140      140              
  Lines        2167     2167              
  Branches      530      530              
==========================================
+ Hits         1589     1617      +28     
+ Misses        573      545      -28     
  Partials        5        5              
Impacted Files Coverage Δ
src/components/Modal/Modal.tsx 100.00% <100.00%> (+71.42%) ⬆️
src/helpers/margin.ts 100.00% <0.00%> (+4.34%) ⬆️
src/components/Popover/Portal.tsx 94.44% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c06818...afd7900. Read the comment docs.

@anitnilay20 anitnilay20 merged commit 82e931d into master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants