Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor flex fixes #84

Merged
merged 11 commits into from
May 29, 2021
Merged

Minor flex fixes #84

merged 11 commits into from
May 29, 2021

Conversation

anitnilay20
Copy link
Contributor

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Go over all the following points, and put an x in all the boxes that apply.
  • If you're unsure about any of these, don't hesitate to ask. We're here to help!
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

prateekshourya29 and others added 11 commits May 29, 2021 18:18
* Use dynamic zIndex assignment.
* Update *CardHeader* to use *h6* for header.
* Modal opening and closing animation fix.
* Popover add classname for child element.
* Add close button with datepicker if timepicker is also there.
* Add fix-width for Datepicker popup.
Use margin and padding props.
@codecov
Copy link

codecov bot commented May 29, 2021

Codecov Report

Merging #84 (6f23fe4) into master (e03ec95) will decrease coverage by 0.14%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   73.46%   73.32%   -0.15%     
==========================================
  Files         141      140       -1     
  Lines        2171     2167       -4     
  Branches      528      530       +2     
==========================================
- Hits         1595     1589       -6     
- Misses        571      573       +2     
  Partials        5        5              
Impacted Files Coverage Δ
src/components/Card/index.ts 100.00% <ø> (ø)
src/components/DatePicker/DatePicker.tsx 35.29% <ø> (ø)
src/components/Input/BaseInputComponent.tsx 100.00% <ø> (ø)
src/components/Table/style.ts 75.00% <ø> (-5.00%) ⬇️
src/helpers/padding.ts 100.00% <ø> (ø)
src/components/Table/FlexTable.tsx 28.88% <50.00%> (-0.66%) ⬇️
src/components/AutoComplete/AutoComplete.tsx 99.20% <100.00%> (ø)
src/components/Calendar/Calendar.tsx 100.00% <100.00%> (ø)
src/components/List/ListItem.tsx 92.85% <100.00%> (ø)
src/components/List/style.ts 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e03ec95...6f23fe4. Read the comment docs.

@prateekshourya29 prateekshourya29 merged commit 1c06818 into master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants