Major fixes. Design and Functionality #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use dynamic zIndex assignment. * Update *CardHeader* to use *h6* for header. * Modal opening and closing animation fix. * Popover add classname for child element.
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 65.93% 73.46% +7.53%
==========================================
Files 136 141 +5
Lines 2049 2171 +122
Branches 458 528 +70
==========================================
+ Hits 1351 1595 +244
+ Misses 698 571 -127
- Partials 0 5 +5
Continue to review full report at Codecov.
|
anitnilay20
requested changes
May 21, 2021
src/components/Grid/Row.tsx
Outdated
| ? (__children as React.ReactElement[]) | ||
| : [__children]; | ||
|
|
||
| const [RowGutterStyles, ColPadding] = gutterStyle(props); |
There was a problem hiding this comment.
The variable name should follow camel casing.
| @@ -28,7 +28,7 @@ export const DatePicker: React.FC<DatePickerProps> = (props) => { | |||
| <> | |||
| <Popover | |||
| content={ | |||
| <Row gutter={['0', '0']}> | |||
| <Row gutter={[0, 0]}> | |||
There was a problem hiding this comment.
Suggested change
| <Row gutter={[0, 0]}> | |
| <Row gutter={0}> |
src/components/Layout/SidePanel.tsx
Outdated
| @@ -60,8 +60,8 @@ const Inner: React.FC<InnerProps> = (props) => { | |||
| onMouseEnter={() => updateDrawerButton(true)} | |||
| onMouseLeave={() => updateDrawerButton(false)} | |||
| > | |||
| <Row gutter={[0, '0 5px 0 5px']} style={{ overflowX: 'hidden', maxWidth: width + 'px' }} wrap="nowrap"> | |||
| <Col flex="0 0 60px" className={elevationCss(3)}> | |||
| <Row gutter={[0, 0]} style={{ overflowX: 'hidden', maxWidth: width + 'px' }} wrap="nowrap"> | |||
There was a problem hiding this comment.
Suggested change
| <Row gutter={[0, 0]} style={{ overflowX: 'hidden', maxWidth: width + 'px' }} wrap="nowrap"> | |
| <Row gutter={0} style={{ overflowX: 'hidden', maxWidth: width + 'px' }} wrap="nowrap"> |
| @@ -38,7 +38,7 @@ export const BasicTableWithHeadersAndFooters: Story<TableProps<{ name: string; a | |||
| }, | |||
| ]} | |||
| header={ | |||
| <Row justifyContent="flex-end" gutter={['0', '0']}> | |||
| <Row justifyContent="flex-end" gutter={[0, 0]}> | |||
There was a problem hiding this comment.
Suggested change
| <Row justifyContent="flex-end" gutter={[0, 0]}> | |
| <Row justifyContent="flex-end" gutter={0}> |
src/helpers/Grid.ts
Outdated
|
|
||
| export function useWindowSize() { | ||
| const [size, setSize] = React.useState([0, 0]); | ||
| React.useLayoutEffect(() => { |
There was a problem hiding this comment.
I think we should use useEffect instead.
Ref: https://reactjs.org/docs/hooks-reference.html#uselayouteffect
* Add close button with datepicker if timepicker is also there. * Add fix-width for Datepicker popup.
anitnilay20
changed the title
* 🎉 Add test for calendar component. * Add key to each tooltip to remove warnings. * Add requested changes.
anitnilay20
approved these changes
May 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Known issues
Types of changes
Checklist